New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(theme): add slash to hotKey search #2328
fix(theme): add slash to hotKey search #2328
Conversation
|
@brc-dd Okay, The validation you referred to was done for the following reason: // The `/` shortcut opens but doesn't close the modal because it's a character.
(!isEditingContent(event) && event.key === '/' && !isOpen) But in our case the |
That comment is for |
@brc-dd I did not understand your comment, could you explain again? This treatment was already necessary before the opening of my PR, since the opening with Suppose treatment should exist, but is it something that should be done in this PR? Obs: I tested with |
Screen.Recording.2023-05-02.at.10.30.27.AM.mov |
@brc-dd Sorry for my mistake, I performed the test before the build so it worked for me. It's my first time working in open source, I'm learning with you. Anyway, I uploaded the corrections |
@brc-dd All good now? |
What is the purpose of this pull request?
Solving this problem here (Vuejs).