Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(isolatedModules): Remove redundant isolatedModules #14

Merged
merged 2 commits into from May 12, 2023

Conversation

lupas
Copy link
Contributor

@lupas lupas commented May 1, 2023

Issue

The following warning is shown when using version 0.3.2:

error TS5104: Option 'isolatedModules' is redundant and cannot be specified with option 'verbatimModuleSyntax'.

Screenshot 2023-05-01 at 11 36 03

As seen in microsoft/TypeScript#53601 (comment), isolatedModules is redundant when using verbatimModuleSyntax: true, and therefore throws this warning.

Solution

By removing isolatedModules from tsconfig.json the warning is gone.

Copy link
Member

@sodatea sodatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Somehow I didn't encounter this issue in my own tests… I really should update my test projects.

@sodatea sodatea merged commit 4d90b13 into vuejs:main May 12, 2023
@kingyue737
Copy link

kingyue737 commented May 12, 2023

Thanks! Somehow I didn't encounter this issue in my own tests… I really should update my test projects.

@sodatea Because it's allowed to use isolatedModules: true with verbatimModuleSyntax: true since v5.0.4. Not your fault XD
microsoft/TypeScript#53611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants