Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): update codesandbox link #2868

Merged
merged 6 commits into from
May 16, 2024

Conversation

Yordan-Ramchev
Copy link
Contributor

@Yordan-Ramchev Yordan-Ramchev commented May 13, 2024

Description of Problem

tooling.md uses broken/old codesandbox link

Proposed Solution

Update tooling.md code sandbox link to https://codesandbox.io/p/devbox/github/codesandbox/sandbox-templates/tree/main/vue-vite which reference https://github.com/codesandbox/sandbox-templates/tree/main/vue-vite

Additional Information

When loading Vue on Components.studio there is an error in there.
Screenshot 2024-05-13 at 9 34 47

Update:
Created bug issue. Reference: divriots/components.studio#6

Copy link

netlify bot commented May 13, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit de326ce
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6644c9ba0aac4700089d8eca
😎 Deploy Preview https://deploy-preview-2868--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Yordan-Ramchev Yordan-Ramchev changed the title feat(playground): update codesandbox link fix(playground): update codesandbox link May 13, 2024
@NataliaTepluhina
Copy link
Member

@Yordan-Ramchev I don't think pnpm-yaml.lock should have been updated in the PR 🤔 could you please revert changes to it and ping me for merging?

@Yordan-Ramchev
Copy link
Contributor Author

@NataliaTepluhina should be good now :)

@NataliaTepluhina
Copy link
Member

@NataliaTepluhina should be good now :)

@Yordan-Ramchev thank you! PR is good to merge now 👍🏻

@NataliaTepluhina NataliaTepluhina merged commit 64bae64 into vuejs:main May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants