Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): should not update style if its not change #5754

Closed
wants to merge 12 commits into from

Conversation

btea
Copy link
Contributor

@btea btea commented Apr 19, 2022

Open the link and follow the steps below:
1、Click the move button, and the left value of div tag will become 20px.
2、Click the add button, the left value of the first div tag should also be 20px.

fix #5772

border and border-* are set at the same time, the browser and unit test rendering results are inconsistent, refer to the following figure
53b506f9fd70c227312e1e0454bbd8d

rel vuejs/vue#12946

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit e467d4d
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6262bda47fb9a100098b1a90
😎 Deploy Preview https://deploy-preview-5754--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit e182bbc
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63ce94ddeca4b500082bb61d

@netlify
Copy link

netlify bot commented Apr 19, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit e467d4d
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6262bda411950b000886989a
😎 Deploy Preview https://deploy-preview-5754--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@btea btea closed this Apr 19, 2022
@btea btea reopened this Apr 22, 2022
@btea btea changed the title fix(runtime-dom): patchstyle should not overwritten the same value fix(runtime-dom): should not update style if its not change Apr 22, 2022
@btea
Copy link
Contributor Author

btea commented Nov 8, 2022

@yyx990803 I think this fix is ​​necessary, WDYT?

@edison1105 edison1105 added the 🐞 bug Something isn't working label Jan 30, 2023
@yyx990803
Copy link
Member

I don't think the issue reported in #5772 is valid due to manual manipulation, and this is a bit different from the Vue 2 case as the bug reported in vuejs/vue#12946 isn't reproducible in Vue 3.

@yyx990803 yyx990803 closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

patchStyle have some problem
3 participants