fix(runtime-dom): fix vShow not respect passing display #10161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
Will add the corresponding test case later, and I think we need an ecosystem ci check. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
yyx990803
added a commit
that referenced
this pull request
Feb 9, 2024
wangdaoo
pushed a commit
to wangdaoo/core
that referenced
this pull request
May 30, 2024
wangdaoo
pushed a commit
to wangdaoo/core
that referenced
this pull request
May 30, 2024
…a v-bind (vuejs#10161) This reverts commit 9b19f09. close vuejs#10294 reopen vuejs#10151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the doc. In this case, I think the correct behavior is when isVisible is false, modal content should not show no matter the display value is, and when isVisible is true, should switch style when click on Change Style button.
One different behavior is that if the
vShowvalue is true but the user explicitly passes indisplay: none, then the PR change will follow thedisplay: nonepassed in by the user instead of ignoring the user input like the current version. I think this is intuitive though.close #10151