Skip to content

Commit

Permalink
perf(runtime): improve getType() GC and speed (#10327)
Browse files Browse the repository at this point in the history
  • Loading branch information
jpsc committed Feb 13, 2024
1 parent 3f92126 commit 603a1e1
Showing 1 changed file with 17 additions and 2 deletions.
19 changes: 17 additions & 2 deletions packages/runtime-core/src/componentProps.ts
Original file line number Diff line number Diff line change
Expand Up @@ -597,8 +597,23 @@ function validatePropName(key: string) {
// use function string name to check type constructors
// so that it works across vms / iframes.
function getType(ctor: Prop<any>): string {
const match = ctor && ctor.toString().match(/^\s*(function|class) (\w+)/)
return match ? match[2] : ctor === null ? 'null' : ''
// Early return for null to avoid unnecessary computations
if (ctor === null) {
return 'null'
}

// Avoid using regex for common cases by checking the type directly
if (typeof ctor === 'function') {
// Using name property to avoid converting function to string
return ctor.name || ''
} else if (typeof ctor === 'object') {
// Attempting to directly access constructor name if possible
const name = ctor.constructor && ctor.constructor.name
return name || ''
}

// Fallback for other types (though they're less likely to have meaningful names here)
return ''
}

function isSameType(a: Prop<any>, b: Prop<any>): boolean {
Expand Down

0 comments on commit 603a1e1

Please sign in to comment.