Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Puppet 8 support #359

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Add Puppet 8 support #359

merged 1 commit into from
Jul 14, 2023

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 3, 2023
@ekohl
Copy link
Member

ekohl commented Jul 4, 2023

voxpupuli/puppet_metadata#91 is intended to fix the Archlinux issue by using the none collection recently added. See #361 for an example run.

smortex
smortex approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Do you want we wait for the Arch fix to be released before merging this?

@ekohl
Copy link
Member

ekohl commented Jul 14, 2023

Do you want we wait for the Arch fix to be released before merging this?

Not really. It's broken everywhere so we can continue without it.

@smortex smortex merged commit c30d3d2 into master Jul 14, 2023
30 of 31 checks passed
@smortex smortex deleted the puppet8_20230723 branch July 14, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bastelfreak @ekohl @smortex