Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more rubocop violations #484

Merged
merged 5 commits into from Feb 17, 2023
Merged

Conversation

bastelfreak
Copy link
Member

No description provided.

@@ -8,3 +8,15 @@ require:
AllCops:
TargetRubyVersion: 2.5
NewCops: enable

Style/TrailingCommaInHashLiteral:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we agreed on using those in voxpupuli/voxpupuli-test#86

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 89.99% // Head: 89.99% // No change to project coverage 👍

Coverage data is based on head (9437acd) compared to base (d3d90ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 9437acd differs from pull request most recent head 42b9a88. Consider uploading reports for the commit 42b9a88 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #484   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files          76       76           
  Lines        1579     1579           
=======================================
  Hits         1421     1421           
  Misses        158      158           
Impacted Files Coverage Δ
lib/json-schema/attributes/type_v4.rb 100.00% <ø> (ø)
lib/json-schema/validators/draft1.rb 100.00% <ø> (ø)
lib/json-schema/validators/draft2.rb 100.00% <ø> (ø)
lib/json-schema/validators/draft3.rb 100.00% <ø> (ø)
lib/json-schema/validators/draft4.rb 100.00% <ø> (ø)
lib/json-schema/validators/draft6.rb 100.00% <ø> (ø)
lib/json-schema/attribute.rb 100.00% <100.00%> (ø)
lib/json-schema/attributes/allof.rb 95.00% <100.00%> (ø)
lib/json-schema/attributes/anyof.rb 100.00% <100.00%> (ø)
lib/json-schema/attributes/extends.rb 74.19% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bastelfreak bastelfreak merged commit d7cd769 into voxpupuli:master Feb 17, 2023
@bastelfreak bastelfreak deleted the rubocop branch February 17, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants