Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Allow users to disable the fix_notebook call #1423

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

ClaytonAstrom
Copy link
Contributor

References

Resolves #1422

Code changes

Simple boolean toggle that is checked to execute fix_notebook, True by default

User-facing changes

N/A

Backwards-incompatible changes

N/A

Copy link
Contributor

Binder 👈 Launch a Binder on branch ClaytonAstrom/voila/main

@ClaytonAstrom ClaytonAstrom changed the title Allow users to disable the fix_notebook call enhancement: Allow users to disable the fix_notebook call Nov 29, 2023
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable to me 👍🏽 Leaving some time for others to review

@trungleduc
Copy link
Member

Thanks!

@trungleduc trungleduc merged commit 0eeda4d into voila-dashboards:main Nov 30, 2023
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to disable fix_notebook to check/resolve kernel validity
3 participants