adding nbextension path to voila config object #1167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
This PR introduces
nbextensions_path
as a configurable value that we can set to override the default Jupyter Server value (as a workaround until Voila moves away entirely from nbextensions to adopt the lab extension system)References
Background on Motivation (credit @SylvainCorlay)
While Voilà is built with JupyterLab components, we use the classic notebook extension system for the widgets, because when Voilà came out, JupyterLab could not use pre-built extensions.
By default, Voilà uses the webpack bundles that are published on npmjs.
But in order to support extensions that have never been published, but are installed locally, we added support for using local notebook extensions.
Jupyter server is the raw server, and it does not come with the notebook frontend, hence it does not have a notion of notebook extensions. As a workaround for applications that have a nbextension path different from the default, we are adding an option
nbextensions_path
to the Voila Configuration object, so that we are not tied to the server default.User-facing changes
introduces a new optional configuration value that users can set to override default server nbextensions path
Backwards-incompatible changes
N/A