Properly check if all fused layers are in the list of targets #12666
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldarkurtic
requested review from
mgoin,
robertgshaw2-redhat and
tlrmchlsmth
as code owners
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
robertgshaw2-redhat
approved these changes
Feb 2, 2025
robertgshaw2-redhat
added
the
ready
mgoin
approved these changes
Feb 3, 2025
jeejeelee
approved these changes
Feb 3, 2025
sahelib25
pushed a commit
to krai/vllm
that referenced
this pull request
Feb 3, 2025
…roject#12666) Thanks @kylesayrs for catching this!
fxmarty-amd
pushed a commit
to fxmarty-amd/vllm
that referenced
this pull request
Feb 7, 2025
…roject#12666) Thanks @kylesayrs for catching this! Signed-off-by: Felix Marty <felmarty@amd.com>
ShangmingCai
pushed a commit
to ShangmingCai/vllm
that referenced
this pull request
Feb 10, 2025
…roject#12666) Thanks @kylesayrs for catching this!
panf2333
pushed a commit
to yottalabsai/vllm
that referenced
this pull request
Feb 18, 2025
…roject#12666) Thanks @kylesayrs for catching this!
kerthcet
pushed a commit
to kerthcet/vllm
that referenced
this pull request
Feb 21, 2025
…roject#12666) Thanks @kylesayrs for catching this!
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Mar 5, 2025
…roject#12666) Thanks @kylesayrs for catching this! Signed-off-by: Linkun Chen <github@lkchen.net>
Said-Akbar
pushed a commit
to Said-Akbar/vllm-rocm
that referenced
this pull request
Mar 7, 2025
…roject#12666) Thanks @kylesayrs for catching this! Signed-off-by: saeediy <saidakbarp@gmail.com>
qscqesze
pushed a commit
to ZZBoom/vllm
that referenced
this pull request
Mar 13, 2025
…roject#12666) Thanks @kylesayrs for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @kylesayrs for catching this!