Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Remove model input dumping when exception #12582

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Jan 30, 2025

Revert #8305. Originally we added this feature hoping to capture model inputs to reproduce an debug illegal memory access (IMA), but seems like none of the bug reporters attached the dumped inputs. Thus, this feature doesn't help us identify the root cause of IMA, but only causes maintenance efforts.

cc @simon-mo @youkaichao

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

remove
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
@mergify mergify bot added the ci/build label Jan 30, 2025
@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 30, 2025
remove
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this is good to remove

@comaniac comaniac enabled auto-merge (squash) February 3, 2025 19:27
@simon-mo simon-mo disabled auto-merge February 3, 2025 21:31
@simon-mo simon-mo merged commit cf58b9c into vllm-project:main Feb 3, 2025
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants