fix(browser): fix chai and loupe deps and silence util.inspect warning
#5339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
sheremet-va
reviewed
Mar 6, 2024
| @@ -31,6 +31,11 @@ export async function setupConsoleLogSpy() { | |||
| return base(...args) | |||
| } | |||
| const stderr = (base: (...args: unknown[]) => void) => (...args: unknown[]) => { | |||
| // silence warning from loupe's node util.inspect with deps optimization | |||
| // https://github.com/vitejs/vite/blob/0c0aeaeb3f12d2cdc3c47557da209416c8d48fb7/packages/vite/src/node/optimizer/esbuildDepPlugin.ts#L227 | |||
| if (typeof args[0] === 'string' && args[0].startsWith('Module "util" has been externalized for browser compatibility. Cannot access "util.inspect" in client code.')) | |||
There was a problem hiding this comment.
This just silences the actual error, Vite should never trigger this error message
There was a problem hiding this comment.
Yeah, I know. This was an only way I found so far to pre-bundle loupe and chai properly without users getting flooded with this auto warning by Vite.
There was a problem hiding this comment.
Still, this just hides the problem. Let's close this PR for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an another idea I had for #5082. This should work in principle, but silencing known warning is not pretty.
Also, Instead of doing yet another
optimizeDepspatch, maybe it's time to start to think about bundling more packages #5278 (comment), but I haven't got through the idea yet.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.