Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite-node): dedupe -v flag #4886

Closed
wants to merge 2 commits into from
Closed

Conversation

GauBen
Copy link

@GauBen GauBen commented Jan 6, 2024

Description

Current vite-node -h output includes -v, --version twice, as cac will add one for us

Options:
  -r, --root <path>    Use specified root directory 
  -c, --config <path>  Use specified config file 
  -m, --mode <mode>    Set env mode 
  -w, --watch          Restart on file changes, similar to "nodemon" 
  --script             Use vite-node as a script runner 
  --options <options>  Use specified Vite server options 
  -v, --version        Output the version number 
  -h, --help           Display help for command 
  -v, --version        Display version number 

I removed custom version handling and let cac do all the work

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit d3ced92
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65992c8c54413600084fd473
😎 Deploy Preview https://deploy-preview-4886--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

sheremet-va commented Jan 6, 2024

There was a reason for this change: #3574
CAC is not consistent with node CLI

@GauBen
Copy link
Author

GauBen commented Jan 6, 2024

Ok sorry for the noise, should we open an issue upstream?

@sheremet-va
Copy link
Member

Ok sorry for the noise, should we open an issue upstream?

No, CAC doesn't have to work like Node CLI, we just need to work around it

@GauBen
Copy link
Author

GauBen commented Jan 6, 2024

That makes sense, let's keep things as they are

Thanks for being so reactive @sheremet-va!

@GauBen GauBen closed this Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants