Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't mock css-module if inline is specified #3952

Merged
merged 4 commits into from Aug 15, 2023
Merged

fix: don't mock css-module if inline is specified #3952

merged 4 commits into from Aug 15, 2023

Commits on Aug 15, 2023

  1. fix: don't mock css-module if inline is specified 

    As per the vite docs here: https://vitejs.dev/guide/features.html#disabling-css-injection-into-the-page

Using the 'inline' query parameter for CSS has different semantics than regular css imports and the expected return value should be a string as the default export.
    @thebanjomatic
    thebanjomatic authored and Adam Hines committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f61fd98 View commit details
    Browse the repository at this point in the history

  2. chore: applying review feedback

    Adam Hines committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    b488dd3 View commit details
    Browse the repository at this point in the history

  3. chore: fixing lint issues

    Adam Hines committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    1352a7f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix/css-inline

    @thebanjomatic
    thebanjomatic committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    ba009ad View commit details
    Browse the repository at this point in the history