Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(supported-databases): update 8.0 to 8.0.* to make it clear to people any version of 8.0.* should work. #1710

Merged
merged 1 commit into from
May 31, 2024

Conversation

dbmurphy
Copy link
Contributor

fix(supported-databases): update 8.0 to 8.0.* to make it clear to people any version of 8.0.* should work.

@dbmurphy dbmurphy force-pushed the mysqld_version_supported_tweaking branch 2 times, most recently from 4d88901 to e8bd994 Compare March 21, 2024 17:54
@mattlord mattlord requested a review from deepthi March 21, 2024 18:02
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit ab98890
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/65fc8148e519460008e2d563
😎 Deploy Preview https://deploy-preview-1710--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…ple any version of 8.0.* should work.

Signed-off-by: David Murphy <david.b.murphy.tx@gmail.com>
@dbmurphy dbmurphy force-pushed the mysqld_version_supported_tweaking branch from 7c0ecd1 to ab98890 Compare March 21, 2024 18:49
@deepthi
Copy link
Member

deepthi commented Mar 26, 2024

I know this was discussed on slack, and I'm kind of with Matt here. MySQL 8.0 is understood to mean to include all minor versions, so I don't see the need to add a *.

@dbmurphy
Copy link
Contributor Author

dbmurphy commented Mar 27, 2024

I know this was discussed on slack, and I'm kind of with Matt here. MySQL 8.0 is understood to mean to include all minor versions, so I don't see the need to add a *.

If that's how you see it, I can't help, but I was clear that multiple people in our organization see it differently, so it is a problem for people who are not as close to the product as we are. I think where @mattlord and I landed, it doesn't hurt anything to add the * to be more precise for others, especially in business and security roles.

The comments were along lines such as "It's ambiguous and unclear if there may be any 8.0.* version or a specific one listed elsewhere" or "Can we only use the 8.0 that they used in the example, which did not change from v18.0 to v19.0"?

@deepthi
Copy link
Member

deepthi commented May 31, 2024

multiple people in our organization see it differently, so it is a problem for people who are not as close to the product as we are.

OK, this is a valid argument. We want docs to be clear to people who might be coming new to them, so let's go ahead and merge this.

@deepthi deepthi merged commit f8abcfd into vitessio:prod May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants