Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Throwaway PR] For debugging races in multi-tenant locking PR #15936

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented May 14, 2024

Description

This PR adds log lines workflow to try to track down races in the codecov workflow.

Tried deleting other workflows but PR shows up as conflicted because of the deleted workflows and refuses to run the codecov workflow :(

#15807

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

rohit-nayak-ps and others added 30 commits May 5, 2024 18:02
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…ace routing rules

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…r a 'real' topo implementation in addition to memtopo

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…re created

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
This reverts commit 23dc487.
This reverts commit 6119992.
This reverts commit f639c60.

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…on logic to topo server

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…spaceRoutingRules

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…k for MoveTables actions. ApplyKeyspaceRoutingRules has been commented out temporarily

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
… e2e test for it

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…d test. Some additional comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…he client side

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
rohit-nayak-ps and others added 5 commits May 13, 2024 20:47
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
…rules-locking' into rohit/multi-tenant-routing-rules-locking

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Copy link
Contributor

vitess-bot bot commented May 14, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 14, 2024
@rohit-nayak-ps rohit-nayak-ps changed the title [Throwaway PR] For debugging races in [Throwaway PR] For debugging races in multi-tenant locking PR May 14, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 14, 2024
@rohit-nayak-ps rohit-nayak-ps force-pushed the rohit/multi-tenant-routing-rules-locking-rohit-debug branch 2 times, most recently from 1c7a9f1 to 2c82f90 Compare May 14, 2024 10:05
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 72.84768% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 8.10%. Comparing base (f118ba2) to head (93592b0).
Report is 89 commits behind head on main.

Files Patch % Lines
go/vt/topo/topo_lock.go 74.32% 19 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 8 Missing ⚠️
go/vt/topotools/routing_rules.go 78.12% 7 Missing ⚠️
go/vt/vtctl/workflow/server.go 0.00% 3 Missing ⚠️
go/vt/vtctl/workflow/utils.go 85.71% 2 Missing ⚠️
go/vt/topo/vschema.go 88.88% 1 Missing ⚠️
go/vt/vtctl/workflow/switcher.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #15936       +/-   ##
===========================================
- Coverage   68.40%    8.10%   -60.30%     
===========================================
  Files        1556      783      -773     
  Lines      195121   106255    -88866     
===========================================
- Hits       133479     8617   -124862     
- Misses      61642    97638    +35996     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps force-pushed the rohit/multi-tenant-routing-rules-locking-rohit-debug branch from f7b3232 to 93592b0 Compare May 14, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants