Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Improve handling of vplayer stalls #15797

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

VReplication: Improve handling of vplayer stalls #15797

wants to merge 33 commits into from
+191 −58

Commits on Apr 25, 2024

  1. Improve handling of vplayer stalls 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    bee30d4 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Add progress timer and test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6e929fe View commit details
    Browse the repository at this point in the history

  2. Fix table name logging 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5f05388 View commit details
    Browse the repository at this point in the history

  3. Make error handling concurrency safe 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e9e5fc5 View commit details
    Browse the repository at this point in the history

  4. More tweaks from self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 16, 2024
    Configuration menu
    Copy the full SHA
    b72bfbe View commit details
    Browse the repository at this point in the history

  5. Lower progress timeout as the overall stall time is a multiple 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ae275a5 View commit details
    Browse the repository at this point in the history

  6. Move progress tracking to vplayer 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 16, 2024
    Configuration menu
    Copy the full SHA
    99e2d86 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Only use the stall detection for replicated user events 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d4517f2 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into vplayer_batch_trx_tim… 

    …eout

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c54c507 View commit details
    Browse the repository at this point in the history

  3. Tweak test a bit 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 17, 2024
    Configuration menu
    Copy the full SHA
    fe85d9f View commit details
    Browse the repository at this point in the history

  4. Try to deflake CI runs 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 17, 2024
    Configuration menu
    Copy the full SHA
    61c2b73 View commit details
    Browse the repository at this point in the history

  5. WiP for row based unit test case 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 17, 2024
    Configuration menu
    Copy the full SHA
    d00ff6c View commit details
    Browse the repository at this point in the history

Commits on May 18, 2024

  1. Derace work 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 18, 2024
    Configuration menu
    Copy the full SHA
    b45ac01 View commit details
    Browse the repository at this point in the history

  2. Add a flag for this new behavior, which will later be disabled by def… 

    …ault

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 18, 2024
    Configuration menu
    Copy the full SHA
    000e5bc View commit details
    Browse the repository at this point in the history

  3. Improve heartbeat management and errors 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 18, 2024
    Configuration menu
    Copy the full SHA
    196bab8 View commit details
    Browse the repository at this point in the history

  4. Update help text 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 18, 2024
    Configuration menu
    Copy the full SHA
    356e2c0 View commit details
    Browse the repository at this point in the history

  5. Add ROW based test case and correct vtcombo help output 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 18, 2024
    Configuration menu
    Copy the full SHA
    e60b61b View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. Test and error message corrections/improvements 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 19, 2024
    Configuration menu
    Copy the full SHA
    24af4aa View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. Use better flag name 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    f496bdf View commit details
    Browse the repository at this point in the history

  2. Reset min heartbeat interval 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    eeb2ee9 View commit details
    Browse the repository at this point in the history

  3. Changes after self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    fb25daa View commit details
    Browse the repository at this point in the history

  4. Minor changes from second self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    729cf34 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into vplayer_batch_trx_tim… 

    …eout

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    341e232 View commit details
    Browse the repository at this point in the history

  6. Remove explicit schema reload 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 20, 2024
    Configuration menu
    Copy the full SHA
    1749d3d View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Fix goroutine leak 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5075125 View commit details
    Browse the repository at this point in the history

  2. Move progress-deadline from tablet flag to workflow option 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7b5c4c5 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. WiP 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 25, 2024
    Configuration menu
    Copy the full SHA
    fb0f29e View commit details
    Browse the repository at this point in the history

  2. Revert move to workflow option work 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 25, 2024
    Configuration menu
    Copy the full SHA
    b060e09 View commit details
    Browse the repository at this point in the history

  3. Reapply vplayer improvement reverted from flag work 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 25, 2024
    Configuration menu
    Copy the full SHA
    bfd67e5 View commit details
    Browse the repository at this point in the history

  4. Reapply one other comment improvement 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 25, 2024
    Configuration menu
    Copy the full SHA
    eeba51b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Add leak checking unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 26, 2024
    Configuration menu
    Copy the full SHA
    3839e90 View commit details
    Browse the repository at this point in the history

  2. Add a few more expected TestMain goroutines to ignore list 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 26, 2024
    Configuration menu
    Copy the full SHA
    d2fea8d View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Remove stallHandler related code 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 28, 2024
    Configuration menu
    Copy the full SHA
    c666b14 View commit details
    Browse the repository at this point in the history