Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use for:range in go test files #15727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmuli
Copy link

@dmuli dmuli commented Apr 16, 2024

Description

Go 1.22 introduced the ability to range over integers in a more concise manner, e.g.

for i := 0; i < n; i++

becomes

for i := range n

Did the change for all go test files.

My first commit on this repo.

Related Issue(s)

#15193

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

N/A

Copy link
Contributor

vitess-bot bot commented Apr 16, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 16, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 16, 2024
@deepthi
Copy link
Member

deepthi commented Apr 17, 2024

@dmuli welcome and thank you for the contribution. This project requires commits to be signed off. You can fix the commit in this PR by doing git commit --amend --signoff followed by a force-push.
Please review our contributing guide and make sure you have followed those guidelines.
Setting up your development environment according to that guide should install a git hook that does the signoff automatically. If that is not the case, please let us know so that we can investigate and fix it.
One of our maintainers will review this PR, and if it looks reasonable, we'll run CI on it at that time.

@systay systay added Type: Internal Cleanup Type: Testing Component: General Changes throughout the code base and removed Type: Internal Cleanup NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 17, 2024
@dmuli
Copy link
Author

dmuli commented Apr 19, 2024

My tests cases on local are failing with the following error

main_test.go:80:
               Error Trace:    /Users/dhananjay/develop/vitess/go/cmd/vttestserver/cli/main_test.go:80
               Error:          Received unexpected error:
                               signal: killed
               Test:           TestPersistentMode

I am trying to fix these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants