schemadiff INSTANT DDL: impossible changes on tables with FULLTEXT index

[shlomi-noach]

Description

INSTANT DDL analysis: one cannot run ADD COLUMN nor DROP COLUMN with INSTANT algorithm on a table that has a FULLTEXT index.

Related Issue(s)

• Feature request: schemadiff to be aware and knowledgeable about INSTANT-capable changes #14877
• schemadiff: using MySQL capabilities to analyze a SchemaDiff and whether changes are applicable instantly/immediately. #14878
• OnlineDDL to use schemadiff version capabilities; refactor some flavor code. #14883

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.42%. Comparing base (1c4cd97) to head (d50720d).

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15725   +/-   ##
=======================================
  Coverage   68.42%   68.42%           
=======================================
  Files        1559     1559           
  Lines      196482   196496   +14     
=======================================
+ Hits       134438   134461   +23     
+ Misses      62044    62035    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mattlord]

LGTM! I can see that these limitations still exist in 8.4: https://dev.mysql.com/doc/refman/8.4/en/innodb-online-ddl-operations.html

Columns cannot be added to tables that use ROW_FORMAT=COMPRESSED, tables with a FULLTEXT index, tables that reside in the data dictionary tablespace, or temporary tables. Temporary tables only support ALGORITHM=COPY.

IMO it's worth noting that this PR is about tables with a FULLTEXT index OR that are using table compression.

[shlomi-noach]

IMO it's worth noting that this PR is about tables with a FULLTEXT index OR that are using table compression.

True, I realized there was a missing check for compressed tables and added it while here.