Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Move ENUM and SET mappings from vplayer to vstreamer #15723

Merged
merged 43 commits into from
May 9, 2024
Merged

VReplication: Move ENUM and SET mappings from vplayer to vstreamer #15723

merged 43 commits into from
May 9, 2024

Commits on Apr 16, 2024

  1. Move enum and set mappings to vstreamer 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    2200fcc View commit details
    Browse the repository at this point in the history

  2. Fix unit test and optimize code 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0fee7d4 View commit details
    Browse the repository at this point in the history

  3. Correct and optimize set handling 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a6b13c8 View commit details
    Browse the repository at this point in the history

  4. Avoid *any* additional allocations in SET handling 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c12a878 View commit details
    Browse the repository at this point in the history

  5. More testing and wip 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b663601 View commit details
    Browse the repository at this point in the history

  6. Improve error handling 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    a540c3b View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into vstream_enum_strings 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8da07ec View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Add JiT mapping support 

    And remove some noisy debug logging.
And remove any OnlineDDL changes for now. Those changes were
premature.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    1f10e2a View commit details
    Browse the repository at this point in the history

  2. Update unit test framework 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    96d50f5 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Properly handle ENUM/SET types when binary collation is used 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f4ea9e5 View commit details
    Browse the repository at this point in the history

  2. Minor changes and test improvements after self review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    5314195 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into vstream_enum_strings 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8339329 View commit details
    Browse the repository at this point in the history

  4. Very minor improvement to dialDedicatedPool's invalidator 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    3d42461 View commit details
    Browse the repository at this point in the history

  5. Final self review and cleanup 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c178406 View commit details
    Browse the repository at this point in the history

  6. Fix evalengine.NullSafeCompare when comparing an ENUM/SET type to a C… 

    …HAR type

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    e1e3774 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. Test cumulative fixes for mapping and comparing 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1c1140a View commit details
    Browse the repository at this point in the history

  2. Add ENUM <-> VARCHAR evalengine compare test cases 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    01d7894 View commit details
    Browse the repository at this point in the history

  3. Minor improvement to e2e test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    822410d View commit details
    Browse the repository at this point in the history

  4. Minor comment improvements 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    cfec6de View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. Add vstream FieldEvent member to signify values are strings 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    2b943bf View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Adjust other tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    e3aae77 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into vstream_enum_strings 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    13fe9b2 View commit details
    Browse the repository at this point in the history

  3. Properly calculate field length for SET columns in unit tests 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6435392 View commit details
    Browse the repository at this point in the history

  4. Update type comment 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    b8e8132 View commit details
    Browse the repository at this point in the history

  5. Revert "Properly calculate field length for SET columns in unit tests" 

    This reverts commit 6435392.

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    53b4ab4 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. remove enumToTextMap in onlineddl/vrepl.go since rule.ConvertEnumToTe… 

    …xt is no longer used

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
    @shlomi-noach
    shlomi-noach committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d2bfdae View commit details
    Browse the repository at this point in the history

  2. Revert "remove enumToTextMap in onlineddl/vrepl.go since rule.Convert… 

    …EnumToText is no longer used"

This reverts commit d2bfdae.
    @shlomi-noach
    shlomi-noach committed May 1, 2024
    Configuration menu
    Copy the full SHA
    349ee79 View commit details
    Browse the repository at this point in the history

  3. Address review comments 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 1, 2024
    Configuration menu
    Copy the full SHA
    aa3359a View commit details
    Browse the repository at this point in the history

  4. Add NULL handling to test framework 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e4db066 View commit details
    Browse the repository at this point in the history

  5. Minor changes after self review of recent commits 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 1, 2024
    Configuration menu
    Copy the full SHA
    3084a93 View commit details
    Browse the repository at this point in the history

  6. Test self nits 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ccf1729 View commit details
    Browse the repository at this point in the history

  7. Event string is more than the column info 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 1, 2024
    Configuration menu
    Copy the full SHA
    65c1ed4 View commit details
    Browse the repository at this point in the history

  8. Some additional minor unit test framework improvements 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6510631 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Remove unnecessary else block 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 2, 2024
    Configuration menu
    Copy the full SHA
    aa518ea View commit details
    Browse the repository at this point in the history

  2. Improve unit test 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 2, 2024
    Configuration menu
    Copy the full SHA
    647de32 View commit details
    Browse the repository at this point in the history

  3. Fix some typos on another self-review 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f5681ac View commit details
    Browse the repository at this point in the history

  4. Another comment improvement 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 2, 2024
    Configuration menu
    Copy the full SHA
    0c62783 View commit details
    Browse the repository at this point in the history

  5. Further comment improvement (nitting myself to deth, send halp) 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 2, 2024
    Configuration menu
    Copy the full SHA
    98374d2 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Add release notes 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 8, 2024
    Configuration menu
    Copy the full SHA
    02b6642 View commit details
    Browse the repository at this point in the history

  2. Tweaking the release notes 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 8, 2024
    Configuration menu
    Copy the full SHA
    0c98605 View commit details
    Browse the repository at this point in the history

  3. More release notes tweaks 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 8, 2024
    Configuration menu
    Copy the full SHA
    edf9fae View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Final set of minor release notes tweaks 

    Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 9, 2024
    Configuration menu
    Copy the full SHA
    0574d2d View commit details
    Browse the repository at this point in the history

  2. Comparison blocks look terrible using json as the language in GitHub … 

    …markdown viewer -- going back to text

Signed-off-by: Matt Lord <mattalord@gmail.com>
    @mattlord
    mattlord committed May 9, 2024
    Configuration menu
    Copy the full SHA
    1584903 View commit details
    Browse the repository at this point in the history