Signed-off-by: Manan Gupta <manan@planetscale.com>

…o#12273)

* Revert default MySQL 80 version



* upgrade mysql80 default to 8.0.30



* Add release notes regarding MySQL upgrade path in the vitess-operator



* Remove unwanted upgrade path step



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Release notes for 16.0.0-rc1

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Release commit for 16.0.0-rc1

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Download mariadb from vitess-resources



* Use proper mariadb version increment in tests



* Use 10.10.3 instead of LTS



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Manan Gupta <manan@planetscale.com>

…sio#12311)

* fix: aggregation coming from right hand side of left join check for null

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: added a sum test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* addressed review comments

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…2281) (vitessio#12308)

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…vitessio#12278)

* Add lib functions to wait for shard states



* Fixup region example too



* Address minor review comments



* Remove extraneous line change



* Refactor to remove duplicated files/code

Also address shellcheck warnings.



* Fix tests that run in CI



* Use more robust location detection



* Fix backup tests



* Exit on shard healthy failure



* Remove unused dups and adjust client_test and Dockerfiles



---------

Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

* feat: proto changes to add new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: vttablet changes in queryservice to implement the new rpc

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* added test on tabletserver

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: use the new schema rpc in vtgate to get updated view definition

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* remove error from getschemaresponse and change the enum name

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* updated proto files for vtadmin

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* fix e2e test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…essio#12320) (vitessio#12362)

* TableFilter: fix excluded RE listing

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* extract GCTableNameExpression

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* VReplication: exclude GC tables when reading schema

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* wrap schema analyzis errors for better tracability

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…vitessio#12381)

* Fix SHOW VSCHEMA TABLES tests using v17 vtgate

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix tests expectations

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.5.0 to 0.7.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](golang/net@v0.5.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

) (vitessio#12406)

* Allow zero (in) date when setting up internal _vt schema



* modify test sto include @@sql_mod query support



* Allow zero (in) date when setting up internal _vt schema



* modify test sto include @@sql_mod query support



* Fix test failures



* Fix failing tests. Minor refactor



* change sql_mode t omost permissive (empty)



* setPermissiveSQLMode



* fixes per review



* Add missing mock query



---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>

* Add release notes summary for support views

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* add link to the documentation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* simplify views release notes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…#12415)

* Examples: correct VTAdmin discovery file path and add check

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove jq dependency

Signed-off-by: Matt Lord <mattalord@gmail.com>

* vtadmin examples scripts hardcode localhost

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix errant expectation

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Adjust healthy shard indicator

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>

This is needed to better support importing from
MariaDB into Vitess/MySQL.

Signed-off-by: Matt Lord <mattalord@gmail.com>

…vitessio#12421)

* Changed getSchemaRPC to return CreateView instead of SelectStmt

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test: fix expectation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* restrict views to single keyspace

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* feat: also create/alter and drop views on MySQL for information-schema-support

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: do the DMLs for alter and create of view in a transaction so that they can be rolled back in case of MySQL failure

Signed-off-by: Manan Gupta <manan@planetscale.com>

* ignore view changes by schema tracker in vttablet when views are enabled

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: fix test expectation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Correct syntax error in defer func of E2E test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…ssio#12426)

* TableFilter: fix excluded RE listing

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* extract GCTableNameExpression

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* VReplication: exclude GC tables when reading schema

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* wrap schema analyzis errors for better tracability

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* resolve conflict

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* (re)Formalize SQLError in VReplication, add underlying wrap/unwrap functionality

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* update test to match new UnwrapAll() behavior

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* do not unwrap

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Online DDL: use LastError for retrying vreplication streams

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* differentiate between a temrinally failed workflow and one which 'has error' and can be retried

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* wording

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* simplified hasError()

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* more onlineddl_vrepl tests; use dynamic throttler config; fix wait for vreplication status

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* examples: should use mysql80 property for vitess image

Signed-off-by: deepthi <deepthi@planetscale.com>

* Use MySQL80 in all examples/operator YAML files

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* feat: fix vtadmin image version

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: update release script to update vtadmin image version too

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix vtop example script to use vtctldclient instead

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: deepthi <deepthi@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Manan Gupta <manan@planetscale.com>

…es (vitessio#12436)

* schemadiff: AlterTableAlgorithmStratgy

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* minor rename

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Use COPY algorithm while altering sidecardb tables

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Dependabot does pick up these go.mod files but somehow fails to open PRs
for them to update things that are vulnerable. So doing it manually
here.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

…ssio#12328) (vitessio#12431)

* Don't fail on schema init errors

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix debug var attribute name

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Fix typo in debug var

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Address review comment

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Address review comments

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Co-authored-by: Rohit Nayak <rohit@planetscale.com>

* GetSchema rpc to streaming api

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* addressed review comment

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…mple (vitessio#12458)

* feat: fix vtctldclient command

Signed-off-by: Manan Gupta <manan@planetscale.com>

* examples: remove enforceSemiSync from operator example

Signed-off-by: deepthi <deepthi@planetscale.com>

* feat: also update vitess operator version

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Co-authored-by: deepthi <deepthi@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: breaking changes should be the first heading

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: reorder the breaking changes in order of user impact

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: VTOrc becoming mandatory is important

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Reorganize the flag deletions and deprecation announcements

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix various typo and add vtorc links

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Upgrading to this release with vitess-operator

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix various typo

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Link to PRs in major changes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com>

…io#12468)

* fix: scalar aggregation truncation

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* test: added scalar aggr engine unit test

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* remove onecase change

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

---------

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Andy Lim <alim@duosecurity.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Co-authored-by: Andy Lim <125596831+andylim-duo@users.noreply.github.com>

…itessio#12475)

Signed-off-by: deepthi <deepthi@planetscale.com>

* Upgrade release-16.0 to go1.19.6

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* upgrade to 1.20.1

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* bump the golangci-lint version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply linter suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix TestTLSClientVerifyIdentity

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Switch to using new Go 1.19 CRL parser (vitessio#12315)

`x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList`
instead which is new in Go 1.19.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Skip TestFuzz for now

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

…sio#12484)

* test: add failing test for a query in an unsharded keyspace using a derived table and reference table

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix logic to check if a single unsharded keyspace is used

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix test output

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>

…io#12503)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>

* Release notes for 16.0.0

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Release commit for 16.0.0

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Minor tweaks after review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Clarify user vs developer for sidecardb schema

Signed-off-by: Matt Lord <mattalord@gmail.com>

* feat: update the summary doc too for future patch releases

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: update release notes and changelog after recent changes

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix summary file to add examples of label change

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: update release notes and changelog

Signed-off-by: Manan Gupta <manan@planetscale.com>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…nd (vitessio#12481) (vitessio#12532)

* Add a Run func to `vtctldclient`'s Root command to return an error on unknown command

Closes vitessio#12480.



* Add test



* flags test data



---------

Signed-off-by: Andrew Mason <andrew@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Improve release process post `v16.0.0 GA` code freeze (vitessio#12487)

* Update the release instructions document with pre-requisites for release team

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Add Do Not Merge to release Pull Request upon creation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Block merge if the `Do Not Merge` label is set (vitessio#12489)

* Block Merge if the  label is set

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix echo syntax

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Online DDL: enforce ALGORITHM=COPY on shadow table

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* unit tests

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* resolve conflict

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* algorithm format

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* revert change to sql.y

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…` Docker build (vitessio#12530) (vitessio#12561)

* Fix dubious ownership of git directory in vitess/base Docker build

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use consistent method to copy and build vitess between base and lite

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix all base Dockerfiles

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…#12555) (vitessio#12556)

* collations: fix sorting in UCA900 collations

When using the fast iterator to _compare_ two strings with an UCA
collation, we need to keep in mind that the weights in the collation are
in BIG ENDIAN (this is the output format for the weight strings, so we
store the weights this way), so comparing them directly will not result
in the proper collation order. They need to be byte-swapped before they
can be compared with an arithmetic operation!

Signed-off-by: Vicent Marti <vmg@strn.cat>

* collations: comment

Signed-off-by: Vicent Marti <vmg@strn.cat>

---------

Signed-off-by: Vicent Marti <vmg@strn.cat>
Co-authored-by: Vicent Marti <vmg@strn.cat>

…vitessio#12520) (vitessio#12576)

* Store throttler config in global Keyspace record

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix unit test after ThrottlerConfig in Keyspace

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Apply changes lost in cherry picks

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Always wait for a status before the final check.

We should not ever make an assumption about how quickly
an operation will take.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Propagate PartialResult and other errs back to client

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vrepl/onlineddl_vrepl_test.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vtctlutil.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Update go/test/endtoend/onlineddl/vtgate_util.go

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* fix grammar

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…sio#12560) (vitessio#12581)

* Examples: wait for shard's vreplication engine to open



* Minor comment changes



---------

Signed-off-by: Matt Lord <mattalord@gmail.com>

…12589)

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…runners (vitessio#12583) (vitessio#12588)

* CI: extend timeouts in onlineddl_vrepl due to slow CI runners

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* increase even further

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Purge logs without panicking



* Purge logs without panicking



* try moving the goroutine to the func itself



---------

Signed-off-by: Andrew Mason <andrew@planetscale.com>

…essio#12630)

* Add signed and unsigned integer types to forked ason library to fix issue of integers being parsed as float64 by the source binlog parser. This results in larger integers being stored as floats on the target and sent with scientific notation in vstream events.

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Use go.mod reference to the ajson module to make it easier to switch to the upstream module once changes are made there

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

---------

Signed-off-by: Rohit Nayak <rohit@planetscale.com>

…og` (vitessio#12566) (vitessio#12660)

* Re-organize the `releasenotes` directory into `changelog` (vitessio#12566)

* Move all release related documents to ./release and add tool to generate READMEs

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Addition of the release.go file

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* simplify release.go

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* generate the release notes in the proper place

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* modify previous mentions of docs/releasenotes

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* re-add v17.0.0 summary

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* add new release tool to release instruction and ci

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* apply review suggestions

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* simplify release notes document path

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply review suggestions and fix team files

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* update the changelog dir and release_notes_label workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

vitessio#12671)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…le (vitessio#12607) (vitessio#12648)

* Fix random aggregation to not select Null column



* stop pushing down projections that should be evaluated at the vtgate level



* undo changes to AggregateRandom



* clean up code



* fix executor test mock



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

…ma (vitessio#12641) (vitessio#12664)

* Mysqld.GetSchema: tolerate tables being dropped while inspecting schema



* lack of primary key columns in STATISTICS does not mean table is dropped. It can also mean the table does not have PRIMARY KEY



* populate validTds rather than rely on nil hints



* re-introdce earlier check



* use validTds, sync



* due to many tests consistently failing, trying a different approach: we keep the table, but with empty column/key/fields info



* grammar



---------

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…io#12670)

* Always add column in the derived operator



* Fix plan tests expectations



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

…tessio#12534) (vitessio#12691)

* feat: fix initialization code to also stop replication



* feat: fix tests expectations



* feat: fix wrangler tests



---------

Signed-off-by: Manan Gupta <manan@planetscale.com>

…#12698)

* [planner bugfix] add expressions to HAVING

When a predicate contains aggregation, it should not
be added to the WHERE clause. It should go to the



* update test expecteations



---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>

…ssio#12709)

* Auto upgrade the Golang version (vitessio#12585)

* initial addition of the go_upgrade tool to detect and bump the golang version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* update go.mod automatically

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix isSameMajor version issue

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* update the bootstrap version automatically

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* update the bootstrap docker image changelog

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* uncomment code

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* addition of base to create-pull-request

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test create PR alternative

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* add flags and getter methods

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* better PR message

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix no-workflow-update flag and better PR body msg

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix PR title, branch and body format

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test matrix and pwd path

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* enhanced matrix

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* update_workflows option

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* update workflows independently

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* test without matrix

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Add docs to go_upgrade and re-add matrix to the workflow

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* support major version upgrade

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* do not update bootstrap version if they are the same

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* migrate to cobra instead of pflags

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove redundant comment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* safety net around replaceGoVersionInCodebase to avoid unrequired upgrade

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Remove double negation in workflowUpdate flag

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Use regexp instead of mere string comparison

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Proper regexp for every string comparison

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* use better regex

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove useless flag and improve the auto-PR body description

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* add note in the tool usage to run the tool at the root of the repo

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* add comment in .github/workflows/update_golang_version.yml

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply @mattlord code suggestion

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* replace usages of old filename

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply suggestions from code review

Co-authored-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>

* Fix regexp

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>

…12721)

* feat: reenable launchable for unit_tests



* feat: only run CI on PRs against main



* feat: use base_ref instead of ref



---------

Signed-off-by: Manan Gupta <manan@planetscale.com>

…itessio#12704) (vitessio#12725)

Signed-off-by: Andres Taylor <andres@planetscale.com>

…er `65,528` parameters (vitessio#12614) (vitessio#12627)

* fix type conversion in query.go for the bitMap size

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* enhance the TestHighNumberOfParams test

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix test comment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
Co-authored-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>

* bump go version to go1.20.2

Signed-off-by: GitHub <noreply@github.com>

* Update the golang version to 1.20.2

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: frouioui <frouioui@users.noreply.github.com>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

)

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* remove unnecessary vtorc process



* Adding vtorc disabling at right place



* Adding comments



---------

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…io#12502) (vitessio#12740)

* Use new healthy shard check in vreplication e2e tests

This is needed because checking that there's a primary tablet for
the shard in vtgate's healtcheck is no longer a reliable indicator
that the shard has a healthy serving primary, because now a
primary needs to initialize its sidecar database and wait for
that to replicate via semi-sync before it becomes serving and can
proceed to perform normal functions. So this delay could cause
test flakiness if you required a healthy shard before continuing
with the test.



* Try to address unit test race flakes around log size

They looked like this:
WARNING: DATA RACE
Write at 0x000005bf9b60 by goroutine 27141:
  github.com/spf13/pflag.newUint64Value()
      /home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.5/uint64.go:9 +0x5a
  github.com/spf13/pflag.(*FlagSet).Uint64Var()
      /home/runner/go/pkg/mod/github.com/spf13/pflag@v1.0.5/uint64.go:45 +0x55
  vitess.io/vitess/go/vt/log.RegisterFlags()
      /home/runner/work/vitess/vitess/go/vt/log/log.go:81 +0x64
  vitess.io/vitess/go/vt/servenv.GetFlagSetFor()
      /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:347 +0x183
  vitess.io/vitess/go/vt/servenv.ParseFlags()
      /home/runner/work/vitess/vitess/go/vt/servenv/servenv.go:326 +0x49
...
Previous read at 0x000005bf9b60 by goroutine 27136:
1744
  github.com/golang/glog.(*syncBuffer).Write()
...

And they most often occurred in the wrangler unit tests, which makes sense
because it creates a log of loggers.



* Revert "Try to address unit test race flakes around log size"

This reverts commit 51992b8.



* Use external cluster vtctld in TestMigrate



* Use subshell vs command output interpolation



* Ingnore any config files in mysql alias



---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>

* planner: fix predicate simplifier



* predicate rewriting: add debug logging



* add debug logging to make the code easier to understand



* address review feedback



* Update go/vt/vtgate/planbuilder/predicate_rewrite_test.go

Nicer panic message




---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@taylor.se>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Andres Taylor <andres@planetscale.com>

…ce=innodb_system are included in the schema (vitessio#12672) (vitessio#12735)

* Use a left join to make sure that tables with tablespace=innodb_system are not skipped when loading the schema (fixes vitessio#12669)

Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>

* Set tablespace on a test table to see if it breaks vstreamer

Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>

---------

Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>
Co-authored-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>

… reader. (vitessio#12683) (vitessio#12741)

* Reset the current lag when closing the replication lag reader.

Signed-off-by: Johan Stenberg <johanstenberg92@github.com>

* Fix tests.

Signed-off-by: Johan Stenberg <johanstenberg92@github.com>

---------

Signed-off-by: Johan Stenberg <johanstenberg92@github.com>
Co-authored-by: Johan Stenberg <johanstenberg92@github.com>

…12546 (vitessio#12745)

* Flakes: Address Common Unit Test Races (vitessio#12546)

* Deflake unit race tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Try to address glog.MaxSize race

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Test w/o using literal copy of glog.MaxSize value in CI

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Make the dialer names truly unique

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Use atomic.Bool for fakesqldb behavior flags (vitessio#12603)

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Max Englander <max@planetscale.com>
Co-authored-by: Matt Lord <mattalord@gmail.com>
Co-authored-by: Max Englander <max@planetscale.com>

…itessio#12748)

Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Hormoz Kheradmand <hkdsun@users.noreply.github.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com>

…ce names (vitessio#12732) (vitessio#12771)

* Update topo {Get,Create}Keyspace to prevent invalid keyspace names (vitessio#12732)

* Update topo {Get,Create}Keyspace to prevent invalid keyspace names

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* embarrassing

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* docs, release notes

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* only validate, do not correct

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* broader restrictions via allow-list

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Revert "broader restrictions via allow-list"

This reverts commit 5354d4f.

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* tighten up release notes scope

Signed-off-by: Andrew Mason <andrew@planetscale.com>

* Update go/vt/topo/keyspace.go

Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>

---------

Signed-off-by: Andrew Mason <andrew@planetscale.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

* update notes and comments

Signed-off-by: Andrew Mason <andrew@planetscale.com>

---------

Signed-off-by: Andrew Mason <andrew@planetscale.com>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

* Release notes for 16.0.1

Signed-off-by: Manan Gupta <manan@planetscale.com>

* Release commit for 16.0.1

Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: fix release notes folder

Signed-off-by: Manan Gupta <manan@planetscale.com>

* rebase after 12732

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com>

…12775)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…e Tests (vitessio#12791)

* Throttler: Expose Tablet's Config & Leverage to Deflake Tests (vitessio#12737)

* Flakes: effectively disable vtorc for deterministic behavior

For example, we stop replication, wait a few seconds, then expect
there to be lag. But vtorc could repair replication during that
wait and then the lag is gone.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Wait for the throttler to be up and running everywhere

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Expose tablet's throttler config and leverage to deflake tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Apply various corrections

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Be more explicit about VTOrc behavior changes

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Note received throttler response when it is unexpected

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fixes from local testing

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Nits from self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Use assert.Equalf on failed assertions

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Ummm, duh.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Try to get rid of last bit of flakiness

Which seemed to revolve around NOT sleeping long enough
after starting all the sleep queries.

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Nits from self review

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Address review comments

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Adjust test for behavior and comment it

And adjust timing

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Align both stale hearbeat checks

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove no longer needed flag

This is because enabling heartbeats with --heartbeat_enable
also results in the replication reporter being enabled:
https://github.com/vitessio/vitess/blob/3d9ef871e42bd20a60ec95997c97ecf0694c1e78/go/vt/vttablet/tabletserver/tabletenv/config.go#L235-L237

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Correct comment

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Correct comment part II: electric boogaloo

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Revert one other minor unnecessary change.

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Post cherry-pick fixup

Signed-off-by: Matt Lord <mattalord@gmail.com>

---------

Signed-off-by: Matt Lord <mattalord@gmail.com>

…essio#12807)

* Automatically add milestone to new Pull Request



* Run the workflow on pull_request_target event



* Use gh pr edit to add milestone



* Use bash instead of go script



---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…tessio#12769) (vitessio#12796)

* Fix incorrect path during release notes generation

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Apply review suggestion

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…itessio#12818)

Signed-off-by: Andrew Mason <andrew@planetscale.com>
Co-authored-by: Andrew Mason <andrew@planetscale.com>

…2822)

We have tests like `TestMoveTablesV2` which end up reading and writing
queries concurrently. This causes the race detector to appropriately
trigger and detect issues here.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

)

…12838) (vitessio#12848)

* fix float issue with bootstrap version increment

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* handle case where there are no minor bootstrap version

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* avoid re-creating Pull Requests

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* remove parse float

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

---------

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>