Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update paths filter action #15254

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Update paths filter action #15254

merged 1 commit into from
Feb 15, 2024

Conversation

frouioui
Copy link
Member

Description

Since dorny/paths-filter#133 is now merged, we can update the paths-filter action to use the upstream repository and not my patched fork. We will be using https://github.com/dorny/paths-filter/releases/tag/v3.0.1.

@frouioui
Update paths filter action
a16dc90 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Feb 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 15, 2024
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Build/CI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 15, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Feb 15, 2024
@frouioui frouioui added Backport to: release-17.0 Needs to be back ported to release-17.0 Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 labels Feb 15, 2024
@frouioui frouioui merged commit 096b8a8 into vitessio:main Feb 15, 2024
115 checks passed
@frouioui frouioui deleted the update-path-filter branch February 15, 2024 21:41
This was referenced Feb 15, 2024
Merged
Merged
vitess-bot pushed a commit that referenced this pull request Feb 15, 2024
@vitess-bot
Update paths filter action (#15254)
f41aa5c 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot bot mentioned this pull request Feb 15, 2024
Merged
frouioui pushed a commit that referenced this pull request Feb 15, 2024
@vitess-bot
[release-19.0] Update paths filter action (#15254) (#15264)
576e2b6 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
frouioui added a commit that referenced this pull request Feb 16, 2024
@vitess-bot @frouioui
[release-17.0] Update paths filter action (#15254) (#15262)
fb28fc0 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
frouioui added a commit that referenced this pull request Feb 16, 2024
@vitess-bot @frouioui
[release-18.0] Update paths filter action (#15254) (#15263)
0a77982 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
JiekerTime pushed a commit to JiekerTime/vitess that referenced this pull request Feb 18, 2024
@frouioui
[release-18.0] Update paths filter action (vitessio#15254) (vitessio#…
3582f67 
…15263)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: zhangjunjie64 <zhangjunjie64@jd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlord mattlord mattlord approved these changes

@ajm188 ajm188 ajm188 approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees
No one assigned
Labels
Backport to: release-17.0 Needs to be back ported to release-17.0 Backport to: release-18.0 Needs to be back ported to release-18.0 Backport to: release-19.0 Needs to be back ported to release-19.0 Component: Build/CI Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frouioui @mattlord @ajm188