Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen4 planner: allow last_insert_id with arguments #13026

Merged
merged 1 commit into from May 8, 2023
Merged

gen4 planner: allow last_insert_id with arguments #13026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 9 additions & 2 deletions go/vt/sqlparser/ast_rewriting.go
View file
Open in desktop
Expand Up @@ -567,12 +567,19 @@ var funcRewrites = map[string]string{
}

func (er *astRewriter) funcRewrite(cursor *Cursor, node *FuncExpr) {
bindVar, found := funcRewrites[node.Name.Lowered()]
lowered := node.Name.Lowered()
if lowered == "last_insert_id" && len(node.Exprs) > 0 {
// if we are dealing with is LAST_INSERT_ID() with an argument, we don't need to rewrite it.
// with an argument, this is an identity function that will update the session state and
// sets the correct fields in the OK TCP packet that we send back
return
}
bindVar, found := funcRewrites[lowered]
Comment on lines +570 to +577
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this check can be moved down. if the function is present in funcRewrites

if !found || (bindVar == DBVarName && !er.shouldRewriteDatabaseFunc) {
return
}
if len(node.Exprs) > 0 {
er.err = vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "Argument to %s() not supported", node.Name.Lowered())
er.err = vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "Argument to %s() not supported", lowered)
return
}
cursor.Replace(bindVarExpression(bindVar))
Expand Down
23 changes: 23 additions & 0 deletions go/vt/vtgate/planbuilder/testdata/dml_cases.json
View file
Open in desktop
Expand Up @@ -6244,5 +6244,28 @@
"user.ref"
]
}
},
{
"comment": "update using last_insert_id with an argument",
"query": "update main.m1 set foo = last_insert_id(foo+1) where id = 12345",
"plan": {
"QueryType": "UPDATE",
"Original": "update main.m1 set foo = last_insert_id(foo+1) where id = 12345",
"Instructions": {
"OperatorType": "Update",
"Variant": "Unsharded",
"Keyspace": {
"Name": "main",
"Sharded": false
},
"TargetTabletType": "PRIMARY",
"MultiShardAutocommit": false,
"Query": "update m1 set foo = last_insert_id(foo + 1) where id = 12345",
"Table": "m1"
},
"TablesUsed": [
"main.m1"
]
}
}
]
37 changes: 37 additions & 0 deletions go/vt/vtgate/planbuilder/testdata/select_cases.json
View file
Open in desktop
Expand Up @@ -7944,6 +7944,43 @@
]
}
},
{
"comment": "allow last_insert_id with argument",
"query": "select last_insert_id(id) from user",
"v3-plan": {
"QueryType": "SELECT",
"Original": "select last_insert_id(id) from user",
"Instructions": {
"OperatorType": "Route",
"Variant": "Scatter",
"Keyspace": {
"Name": "user",
"Sharded": true
},
"FieldQuery": "select last_insert_id(id) from `user` where 1 != 1",
"Query": "select last_insert_id(id) from `user`",
"Table": "`user`"
}
},
"gen4-plan": {
"QueryType": "SELECT",
"Original": "select last_insert_id(id) from user",
"Instructions": {
"OperatorType": "Route",
"Variant": "Scatter",
"Keyspace": {
"Name": "user",
"Sharded": true
},
"FieldQuery": "select last_insert_id(id) from `user` where 1 != 1",
"Query": "select last_insert_id(id) from `user`",
"Table": "`user`"
},
"TablesUsed": [
"user.user"
]
}
},
{
"comment": "merge subquery using MAX and join into single route",
"query": "select 1 from user join music_extra on user.id = music_extra.user_id where music_extra.music_id = (select max(music_id) from music_extra where user_id = user.id)",
Expand Down