Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolving type errorApi. #542

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

DhairyaMajmudar
Copy link
Contributor

@DhairyaMajmudar DhairyaMajmudar commented May 5, 2024

What kind of change does this PR introduce?

Resolving errorApi types from files:

  1. ForeignKeysPage.tsx
  2. MacroPage.tsx
  3. MacroQueriesComparePage.tsx

By making useState of type null and string: useState<null | string>(null)

Also added string type to errorApi constant in utils.ts file.

Issue Number: N/A

Screenshots/videos:
N/A

Summary

Removed typescript problems coming from errorApi.

Does this PR introduce a breaking change?

@DhairyaMajmudar
Copy link
Contributor Author

@frouioui ping for PR review : )

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@frouioui frouioui merged commit f514475 into vitessio:main May 20, 2024
5 of 6 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the error_type branch May 21, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants