Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scripts and styles were missing from built HTML on Windows #16421

Merged
merged 3 commits into from
May 1, 2024
Merged

fix: scripts and styles were missing from built HTML on Windows #16421

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e31481
fix HTML entry file generation under Windows where different path sep…
rse Apr 13, 2024
5fc290c
test: add test
sapphi-red Apr 30, 2024
164f355
fix: correctly
sapphi-red Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/vite/src/node/plugins/html.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,9 +775,10 @@ export function buildHtmlPlugin(config: ResolvedConfig): Plugin {
}

for (const [id, html] of processedHtml) {
sapphi-red marked this conversation as resolved.
Show resolved Hide resolved
const normalizedId = normalizePath(id)
const relativeUrlPath = path.posix.relative(
config.root,
normalizePath(id),
normalizedId,
)
const assetsBase = getBaseInHTML(relativeUrlPath, config)
const toOutputFilePath = (
Expand Down Expand Up @@ -813,7 +814,7 @@ export function buildHtmlPlugin(config: ResolvedConfig): Plugin {
(chunk) =>
chunk.type === 'chunk' &&
chunk.isEntry &&
chunk.facadeModuleId === id,
chunk.facadeModuleId === normalizedId,
) as OutputChunk | undefined

let canInlineEntry = false
Expand Down