Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(assets): avoid splitting , inside query parameter of image URI in srcset property #16081

Merged
merged 7 commits into from
Mar 17, 2024
Merged

fix(assets): avoid splitting , inside query parameter of image URI in srcset property #16081

merged 7 commits into from
Mar 17, 2024

Commits on Mar 3, 2024

  1. capture string with ? and ,

    @caseycarroll
    caseycarroll committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    f649570 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. add more tests

    @caseycarroll
    caseycarroll committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8d29c13 View commit details
    Browse the repository at this point in the history

  2. use + instead of * for QP comma regex

    @caseycarroll
    caseycarroll committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    5b6e756 View commit details
    Browse the repository at this point in the history

  3. modify no descriptor test

    @caseycarroll
    caseycarroll committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    c5f729f View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. simplify regex

    @caseycarroll
    caseycarroll committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    9b990b8 View commit details
    Browse the repository at this point in the history

  2. change 

    \w to \S to catch symbols
    @caseycarroll
    caseycarroll committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    466dd7a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. simplify regex pattern for readability

    @caseycarroll
    caseycarroll committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    1cb74f8 View commit details
    Browse the repository at this point in the history