Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: temporary hack to avoid fs checks for /@react-refresh #15299

Merged
merged 4 commits into from
Dec 12, 2023
Merged

perf: temporary hack to avoid fs checks for /@react-refresh #15299

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
877b184
perf: avoid fs check for absolute path starting with /@
patak-dev Dec 10, 2023
6f4224c
chore: only apply the workaround for /@react-refresh
patak-dev Dec 12, 2023
799222d
chore: merge main
patak-dev Dec 12, 2023
a9e616e
chore: update comment
patak-dev Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/vite/src/node/plugins/importAnalysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,11 @@ export function importAnalysisPlugin(config: ResolvedConfig): Plugin {
url = resolved.id.slice(root.length)
} else if (
depsOptimizer?.isOptimizedDepFile(resolved.id) ||
(path.isAbsolute(cleanUrl(resolved.id)) &&
// vite-plugin-react isn't following the leading \0 virtual module convention.
// This is a temporary hack to avoid expensive fs checks for React apps.
// We'll remove this as soon we're able to fix the react plugins.
(resolved.id !== '/@react-refresh' &&
path.isAbsolute(resolved.id) &&
fsUtils.existsSync(cleanUrl(resolved.id)))
) {
// an optimized deps may not yet exists in the filesystem, or
Expand Down