Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add md/mdx into KNOWN_ASSET_TYPES for @mdx-js/rollup #15282

Closed
wants to merge 1 commit into from

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Dec 7, 2023

Description

close #15281

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

I didn't include declare module for *.md and *.mdx because it is bundled to use @types/mdx in @mdx-js/rollup.

Copy link

stackblitz bot commented Dec 7, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@JounQin JounQin changed the title fix: add md/mdx into KNOWN_ASSET_TYPES for @mdx-js/rollup fix: add md/mdx into KNOWN_ASSET_TYPES for @mdx-js/rollup Dec 7, 2023
@sapphi-red
Copy link
Member

This will make import foo from './foo.md'; console.log(foo) to return a URL. I guess that's not what you want.

@JounQin
Copy link
Contributor Author

JounQin commented Dec 9, 2023

This will make import foo from './foo.md'; console.log(foo) to return a URL. I guess that's not what you want.

Oh... Right! This is exactly #15284!


So how can we fix #15281 do you think?

@JounQin
Copy link
Contributor Author

JounQin commented Dec 9, 2023

close in favor of #15286

@JounQin JounQin closed this Dec 9, 2023
@JounQin JounQin deleted the fix/md_mdx branch December 9, 2023 08:19
@sapphi-red
Copy link
Member

I guess #15286 will fix #15281. I'm going to take a look.

@JounQin
Copy link
Contributor Author

JounQin commented Dec 9, 2023

I guess #15286 will fix #15281. I'm going to take a look.

Yes, I confirm that patch works to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: No loader is configured for ".md" files after v5 on development with @mdx-js/rollup
2 participants