Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scan .marko files #14669

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: scan .marko files #14669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61409f0
feat: scan .marko files
patak-dev Oct 17, 2023
8ebc427
chore: update comment
patak-dev Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/vite/src/node/optimizer/scan.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,13 @@ function shouldExternalizeDep(resolvedId: string, rawId: string): boolean {
}

function isScannable(id: string): boolean {
return JS_TYPES_RE.test(id) || htmlTypesRE.test(id)
// From Vite 5, all optimizeDeps.extensions are scannable. We hardcode .marko for 4.5.0 to avoid
// potential regressions. See https://github.com/vitejs/vite/pull/14543
return (
JS_TYPES_RE.test(id) ||
htmlTypesRE.test(id) ||
path.extname(id) === '.marko'
)
}

// esbuild v0.18 only transforms decorators when `experimentalDecorators` is set to `true`.
Expand Down