Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ssr): proper test coverage of SSR shebang import hoisting #14448

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

rtsao
Copy link
Contributor

@rtsao rtsao commented Sep 22, 2023

Description

The current test for import hoisting with shebang doesn't actually test the actual hoisting logic because the import is not referenced. This means there is no coverage of actual hoisting. This test still passes even if hoisting is broken by a change such as: #14441.

By including usage of the import that needs hoisting, this ensures proper test coverage of the hoisting logic with shebangs.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@rtsao rtsao changed the title Better test coverage of shebang import hoisting fix(tests): proper test coverage of shebang import hoisting Sep 22, 2023
@rtsao rtsao changed the title fix(tests): proper test coverage of shebang import hoisting fix(tests): proper test coverage of SSR shebang import hoisting Sep 22, 2023
@rtsao rtsao force-pushed the additional-shebang-coverage branch 2 times, most recently from 1caa3dd to 9260af5 Compare September 22, 2023 16:24
@Dunqing
Copy link
Contributor

Dunqing commented Sep 23, 2023

Thanks for this case, I did change kept hoist import statement. I think this should be solve

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy changed the title fix(tests): proper test coverage of SSR shebang import hoisting test(ssr): proper test coverage of SSR shebang import hoisting Sep 25, 2023
@bluwy bluwy merged commit fdd4669 into vitejs:main Sep 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants