Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if host is specified check whether it is valid #14013

Merged
merged 6 commits into from Aug 22, 2023
Merged

fix: if host is specified check whether it is valid #14013

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f94960f
fix: if host is specified check whether it is valid
btea Aug 3, 2023
c624cc0
fix: update if statement
btea Aug 3, 2023
263c3b1
fix: add type parameter
btea Aug 15, 2023
081274a
chore: remove unnecessary if statement
btea Aug 16, 2023
c27fa1d
Merge branch 'fix/check-host' of github.com:btea/vite into fix/check-…
btea Aug 16, 2023
0cbdf51
chore: update comment
bluwy Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/vite/src/node/cli.ts
View file
Open in desktop
Expand Up @@ -102,6 +102,16 @@ function cleanOptions<Options extends GlobalCLIOptions>(
return ret
}

/***
* host may be a number(like 0), should convert to string
*/
bluwy marked this conversation as resolved.
Show resolved Hide resolved
const convertHost = (v: any) => {
if (typeof v === 'number') {
return String(v)
}
return v
}

cli
.option('-c, --config <file>', `[string] use specified config file`)
.option('--base <path>', `[string] public base path (default: /)`)
Expand All @@ -116,7 +126,7 @@ cli
.command('[root]', 'start dev server') // default command
.alias('serve') // the command is called 'serve' in Vite's API
.alias('dev') // alias to align with the script name
.option('--host [host]', `[string] specify hostname`)
.option('--host [host]', `[string] specify hostname`, { type: [convertHost] })
.option('--port <port>', `[number] specify port`)
.option('--https', `[boolean] use TLS + HTTP/2`)
.option('--open [path]', `[boolean | string] open browser on startup`)
Expand Down Expand Up @@ -306,7 +316,7 @@ cli
// preview
cli
.command('preview [root]', 'locally preview production build')
.option('--host [host]', `[string] specify hostname`)
.option('--host [host]', `[string] specify hostname`, { type: [convertHost] })
.option('--port <port>', `[number] specify port`)
.option('--strictPort', `[boolean] exit if specified port is already in use`)
.option('--https', `[boolean] use TLS + HTTP/2`)
Expand Down