Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): style insert order for UMD builds (fix #13668) #13669

Merged
merged 3 commits into from
Jul 14, 2023
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/vite/src/node/plugins/css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -684,9 +684,10 @@ export function cssPostPlugin(config: ResolvedConfig): Plugin {
`document.head.appendChild(${style});`
const wrapIdx = code.indexOf('System.register')
const executeFnStart =
code.indexOf('{', code.indexOf('execute:', wrapIdx)) + 1
wrapIdx >= 0 ? code.indexOf('execute:', wrapIdx) : 0
const injectionPoint = code.indexOf('{', executeFnStart) + 1
const s = new MagicString(code)
s.appendRight(executeFnStart, injectCode)
s.appendRight(injectionPoint, injectCode)
binary-koan marked this conversation as resolved.
Show resolved Hide resolved
if (config.build.sourcemap) {
// resolve public URL from CSS paths, we need to use absolute paths
return {
Expand Down