-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support UTF-8 encoding in inline Web Workers (fixes #12117) #12122
Conversation
Thank you, this fixed my problem at least :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Would you resolve conflicts and add a test for this somewhere inside playground/worker?
Note for reviewers: |
Co-authored-by: 翠 / green <green@sapphi.red>
Thanks @Simolation! I think I face the same issue. How can I use your fix? |
@xiaohk This PR needs the conflicts to be resolved and a test to be added. You can help this PR to be merged by contributing these changes. |
Hmm encountered the same error again 😭 |
I'd love to help. It seems I can't make changes to this PR, so I created a new PR #15866. @sapphi-red can you help review it please? Thank you!! |
Description
fixes #12117
This PR solves issue #12117, where inline Web Workers lose UTF-8 characters due to the atob function, which only supports ASCII. See https://developer.mozilla.org/en-US/docs/Glossary/Base64
The bug can be seen in this reproduction repo: https://stackblitz.com/edit/vitejs-vite-tyt9yp
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).