Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsconfig jsx overrides esbuild options, reverts #10374 #10714

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

sapphi-red
Copy link
Member

Description

This PR reverts #10374.
That PR caused many breakage than I expected.

When tsconfig.json's jsx field has 'preserve' and esbuild.jsx: 'transform' in vite.config.js, 'preserve' is applied. (Previously 'transform' was applied.)
So tsconfig.json has precedence over esbuild options. This is similar to #10296.

I think we should revert this one and reintroduce this in Vite 4. (Maybe esbuild options should have precedence)

fixes #10670
fixes #10685
fixes #10702

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release labels Oct 30, 2022
@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 30, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev
Copy link
Member

The svelte error in ecosystem-ci is an unrelated type error, cc @bluwy

@patak-dev patak-dev merged commit aacf6a4 into vitejs:main Oct 30, 2022
@sapphi-red sapphi-red deleted the fix/esbuild-jsx branch October 31, 2022 11:38
@bluwy bluwy mentioned this pull request Nov 23, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority) regression The issue only appears after a new release
Projects
None yet
2 participants