feat: scan .marko files #14669
Merged
feat: scan .marko files #14669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
added
the
p3-downstream-blocker
bluwy
previously approved these changes
Oct 17, 2023
sapphi-red
previously approved these changes
Oct 17, 2023
| @@ -661,7 +661,13 @@ function shouldExternalizeDep(resolvedId: string, rawId: string): boolean { | |||
| } | |||
|
|
|||
| function isScannable(id: string): boolean { | |||
| return JS_TYPES_RE.test(id) || htmlTypesRE.test(id) | |||
| // From Vite 5, all optimizeDeps.extensions are scannable. We harcode .marko for 4.10.0 to avoid | |||
There was a problem hiding this comment.
The next version would be 4.5.0.
Or do we want to bump to 4.10.0 to declare it's the last version of 4.x?😆
(It reminds me of TypeScript 3.3.3333 thing)
There was a problem hiding this comment.
hahaha, now I want to keep the comment so it is 4.x 😆
patak-dev
commented
Oct 18, 2023
sapphi-red
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hardcode
.markofiles as scannable. See #14536 (comment) for more information.What is the purpose of this pull request?