Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: if host is specified check whether it is valid #14013

Merged
merged 6 commits into from Aug 22, 2023
Merged

fix: if host is specified check whether it is valid #14013

merged 6 commits into from Aug 22, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Aug 3, 2023

Description

fix #14009

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 3, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Aug 16, 2023
sapphi-red
sapphi-red previously approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy enabled auto-merge (squash) August 22, 2023 07:53
@bluwy bluwy merged commit c39e6c1 into vitejs:main Aug 22, 2023
11 checks passed
@btea btea deleted the fix/check-host branch August 22, 2023 08:38
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@btea @bluwy
fix: if host is specified check whether it is valid (#14013)
eda46c3
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@btea @bluwy
fix: if host is specified check whether it is valid (#14013)
b1b816a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red left review comments

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error when starting vue3 dev server: TypeError: hostnameName.includes is not a function
3 participants
@btea @bluwy @sapphi-red