make compressor configurable #9914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkmuffme
force-pushed
the
compressor-configurable-lz4-deflate-off
branch
from
12e49f9
to
ad3fac9
Compare
which was removed in vimeo#9889 - now we won't report for every error but if there are at least 10 errors (chosen arbitrarily)
kkmuffme
force-pushed
the
compressor-configurable-lz4-deflate-off
branch
from
49fc00e
to
90b047c
Compare
|
@orklah please merge |
dkarlovi
suggested changes
Jun 13, 2023
|
@orklah please merge. If people really want to change the cache behavior from what we had previously to completely ignore failures, then that should be a separate PR, where the errors for cache writes are ignored too to keep it consistent. |
cache misses/errros can be a debug log? or write to stderr even |
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Jun 18, 2023
which was removed in vimeo#9889 - now we won't report for every error but if there are at least 10 errors (chosen arbitrarily) Cherry picked from vimeo#9914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make compressor configurable for lz4, deflate (gzip/zlib) or off.
Fix #9905