Fix detecting magic static methods #10704

issidorov · 2024-02-13T17:27:02Z

Key fixes for static magic methods:

behavior with @psalm-seal-methods and related...
detection the issue "InvalidStaticInvocation"
detection the issue "NonStaticSelfCall"

List failed tests: ``` 1) Psalm\Tests\MagicMethodAnnotationTest::testNoSealAllMethodsWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. 2) Psalm\Tests\MagicMethodAnnotationTest::testSealAllMethodsWithoutFooWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. 3) Psalm\Tests\MagicMethodAnnotationTest::testInvalidCode with data set "inheritSealedMethodsWithStatic" Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ```

Appended problem by that commit: ``` 1) FileReferenceTest::testReferencedMethods with data set "getClassReferences" Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ 'foo\b::__construct' => true 'foo\c::foo' => true ) - 'foo\c::__construct' => Array &2 ( + 'foo\a::__callstatic' => Array &2 ( + 'foo\b::__construct' => true + ) + 'foo\c::__construct' => Array &3 ( 'foo\b::bar' => true ) ) ```

Resolved problem: ``` FileReferenceTest::testReferencedMethods with data set "getClassReferences" Failed asserting that two arrays are identical. --- Expected +++ Actual @@ @@ 'foo\b::__construct' => true 'foo\c::foo' => true ) - 'foo\c::__construct' => Array &2 ( + 'foo\a::__callstatic' => Array &2 ( + 'foo\b::__construct' => true + ) + 'foo\c::__construct' => Array &3 ( 'foo\b::bar' => true ) ) ```

The main task for deleting: ``` $method_id = new MethodIdentifier( $fq_class_name, '__callstatic', ); ``` List of resolved problems: ``` 1) Psalm\Tests\MagicMethodAnnotationTest::testNoSealAllMethodsWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. 2) Psalm\Tests\MagicMethodAnnotationTest::testSealAllMethodsWithoutFooWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. 3) Psalm\Tests\MagicMethodAnnotationTest::testInvalidCode with data set "inheritSealedMethodsWithStatic" Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ``` Appended problem by that fix: ``` 1) MagicMethodAnnotationTest::testSealAllMethodsSetToFalseWithStatic Psalm\Exception\CodeException: UndefinedMagicMethod - somefile.php:8:15 - Magic method B::foo does not exist ```

Resolved problem: ``` 1) MagicMethodAnnotationTest::testSealAllMethodsSetToFalseWithStatic Psalm\Exception\CodeException: UndefinedMagicMethod - somefile.php:8:15 - Magic method B::foo does not exist ```

Failed test: ``` 1) MagicMethodAnnotationTest::testAnnotationWithoutCallConfigWithExtendsWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ```

Resolved error: ``` MagicMethodAnnotationTest::testAnnotationWithoutCallConfigWithExtendsWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ``` Appended problem: ``` MagicMethodAnnotationTest::testValidCode with data set "magicStaticMethodInheritanceWithoutCallStatic" Psalm\Exception\CodeException: UndefinedMethod - src/somefile.php:9:32 - Method B::bar does not exist ```

This test has been failed with an error "UndefinedMethod". This error is being issued correctly. But so that this error would not interfere with the test, it was suppressed. Fixed problem: ``` MagicMethodAnnotationTest::testValidCode with data set "magicStaticMethodInheritanceWithoutCallStatic" Psalm\Exception\CodeException: UndefinedMethod - src/somefile.php:9:32 - Method B::bar does not exist ```

Failed tests: ``` 1) MagicMethodAnnotationTest::testInvalidCode with data set "staticInvocationWithInstanceMethodFoo" Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. 2) MagicMethodAnnotationTest::testInvalidCode with data set "nonStaticSelfCallWithInstanceMethodFoo" Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ```

The code has been moved from down to up. Resolved problems: ``` 1) MagicMethodAnnotationTest::testInvalidCode with data set "staticInvocationWithInstanceMethodFoo" Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. 2) MagicMethodAnnotationTest::testInvalidCode with data set "nonStaticSelfCallWithInstanceMethodFoo" Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ```

Description of motivation. We currently have two different behaviors for the code related to "CodeException": ``` $codebase->config->throw_exception = true; // or false ``` If "throw_exception" is set to `true`, code execution stops. If "throw_exception" is set to `false`, the code may continue to execute, and an error may potentially occur. This commit allows testing for the second case, when the value of "throw_exception" will be "false".

Failed tests: ``` 1) Psalm\Tests\MagicMethodAnnotationTest::testInvalidCodeWithIssues with data set "staticInvocationWithMagicMethodFoo" UnexpectedValueException: Cannot get method params for A::foo 2) Psalm\Tests\MagicMethodAnnotationTest::testInvalidCodeWithIssues with data set "nonStaticSelfCallWithMagicMethodFoo" UnexpectedValueException: Cannot get method params for B::foo ```

Resolved problems: ``` 1) Psalm\Tests\MagicMethodAnnotationTest::testInvalidCodeWithIssues with data set "staticInvocationWithMagicMethodFoo" UnexpectedValueException: Cannot get method params for A::foo 2) Psalm\Tests\MagicMethodAnnotationTest::testInvalidCodeWithIssues with data set "nonStaticSelfCallWithMagicMethodFoo" UnexpectedValueException: Cannot get method params for B::foo ```

weirdan · 2024-02-13T20:09:50Z

src/Psalm/Internal/Analyzer/Statements/Expression/Call/Method/MethodVisibilityAnalyzer.php

@@ -40,6 +40,8 @@ public static function analyze(
        $fq_classlike_name = $method_id->fq_class_name;
        $method_name = $method_id->method_name;

+        $with_pseudo = true;


It's not used until line N70, so move it there, perhaps?

I've been thinking about it too.
This is a declaration of a local variable.
And it seemed to me more beautiful to do this at the beginning of the method, next to the declaration of other variables.

Does it need to be fixed? Please confirm.

tests/MagicMethodAnnotationTest.php

tests/Traits/InvalidCodeAnalysisWithIssuesTestTrait.php

tests/TestCase.php

tests/Traits/InvalidCodeAnalysisWithIssuesTestTrait.php

Apply suggestions from code review. Co-authored-by: Bruce Weirdan <weirdan@gmail.com>

tests/TestCase.php

tests/MagicMethodAnnotationTest.php

tests/Traits/InvalidCodeAnalysisWithIssuesTestTrait.php

Co-authored-by: Bruce Weirdan <weirdan@gmail.com>

Apply suggestions from code review. Failed tests: ``` 1) MagicMethodAnnotationTest::testValidCode with data set "magicStaticMethodInheritanceWithoutCallStatic" Psalm\Exception\CodeException: UnusedPsalmSuppress - src/somefile.php:9:58 - This suppression is never used 2) MagicMethodAnnotationTest::testValidCode with data set "magicStaticMethodInheritanceWithoutCallStatic_WithReturnAndManyArgs" Psalm\Exception\CodeException: TooManyArguments - src/somefile.php:9:6 - Too many arguments for B::bar - expecting 0 but saw 2 ``` Co-authored-by: Bruce Weirdan <weirdan@gmail.com>

Apply suggestions from code review. Resolved problems: ``` 1) MagicMethodAnnotationTest::testValidCode with data set "magicStaticMethodInheritanceWithoutCallStatic" Psalm\Exception\CodeException: UnusedPsalmSuppress - src/somefile.php:9:58 - This suppression is never used 2) MagicMethodAnnotationTest::testValidCode with data set "magicStaticMethodInheritanceWithoutCallStatic_WithReturnAndManyArgs" Psalm\Exception\CodeException: TooManyArguments - src/somefile.php:9:6 - Too many arguments for B::bar - expecting 0 but saw 2 ```

weirdan · 2024-02-17T14:45:29Z

Thanks!

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [phpstan/phpstan](https://togithub.com/phpstan/phpstan) | `1.10.59` -> `1.10.60` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/phpstan%2fphpstan/1.10.60?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpstan%2fphpstan/1.10.60?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpstan%2fphpstan/1.10.59/1.10.60?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpstan%2fphpstan/1.10.59/1.10.60?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [phpunit/phpunit](https://phpunit.de/) ([source](https://togithub.com/sebastianbergmann/phpunit)) | `10.5.11` -> `10.5.12` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/phpunit%2fphpunit/10.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/phpunit%2fphpunit/10.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/phpunit%2fphpunit/10.5.11/10.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/phpunit%2fphpunit/10.5.11/10.5.12?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [vimeo/psalm](https://togithub.com/vimeo/psalm) | `5.22.2` -> `5.23.0` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.22.2/5.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.22.2/5.23.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>phpstan/phpstan (phpstan/phpstan)</summary> ### [`v1.10.60`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.60) [Compare Source](https://togithub.com/phpstan/phpstan/compare/1.10.59...1.10.60) [**Learn more about this release**](https://phpstan.org/blog/enhancements-in-handling-parameters-passed-by-reference) in an article on phpstan.org! # Major new features 🚀 - Generic `@method` tags: `@method T doFoo<T>(T $p)`, [#6371](https://togithub.com/phpstan/phpstan/issues/6371) - [Learn more](https://twitter.com/OndrejMirtes/status/1760994823073370509) - [#2931](https://togithub.com/phpstan/phpstan-src/pull/2931), [#2935](https://togithub.com/phpstan/phpstan-src/pull/2935), thanks [@mad-briller](https://togithub.com/mad-briller)! - Generic callable types: `callable<T>(T): T`, [#8964](https://togithub.com/phpstan/phpstan/issues/8964) - [#2938](https://togithub.com/phpstan/phpstan-src/pull/2938), [#2945](https://togithub.com/phpstan/phpstan-src/pull/2945), [#2946](https://togithub.com/phpstan/phpstan-src/pull/2946), thanks [@mad-briller](https://togithub.com/mad-briller)! - Error on references of prefixed internal class names from PHAR files ([#2932](https://togithub.com/phpstan/phpstan-src/pull/2932)), thanks [@staabm](https://togithub.com/staabm)! # Bleeding edge 🔪 - **Enhancements in Handling Parameters Passed by Reference** - [Learn more on phpstan.org](https://phpstan.org/blog/enhancements-in-handling-parameters-passed-by-reference) - [#2941](https://togithub.com/phpstan/phpstan-src/pull/2941), thanks [@ljmaskey](https://togithub.com/ljmaskey)! - Add option `reportAnyTypeWideningInVarTag` ([#2840](https://togithub.com/phpstan/phpstan-src/pull/2840)), thanks [@janedbal](https://togithub.com/janedbal)! *If you want to see the shape of things to come and adopt bleeding edge features early, you can include this config file in your project's `phpstan.neon`:* includes: - vendor/phpstan/phpstan/conf/bleedingEdge.neon *Of course, there are no backwards compatibility guarantees when you include this file. The behaviour and reported errors can change in minor versions with this file included. [Learn more](https://phpstan.org/blog/what-is-bleeding-edge)* # Improvements 🔧 - Add support for constructor assertions ([#2950](https://togithub.com/phpstan/phpstan-src/pull/2950)), [#10645](https://togithub.com/phpstan/phpstan/issues/10645), thanks [@axlon](https://togithub.com/axlon)! - Report uses of deprecated constants ([#2953](https://togithub.com/phpstan/phpstan-src/pull/2953)), thanks [@staabm](https://togithub.com/staabm)! # Bugfixes 🐛 - Fix how union of callables is understood ([#2902](https://togithub.com/phpstan/phpstan-src/pull/2902)), [#10442](https://togithub.com/phpstan/phpstan/issues/10442), thanks [@mad-briller](https://togithub.com/mad-briller)! - Fix for inferring closure parameter type from callable union (phpstan/phpstan-src@c10476d) - ArrayType - string offset might exist as integer offset ([#2928](https://togithub.com/phpstan/phpstan-src/pull/2928)), [#10610](https://togithub.com/phpstan/phpstan/issues/10610), thanks [@michalbundyra](https://togithub.com/michalbundyra)! - Truncate description of huge UnionType (phpstan/phpstan-src@039a3dc), [#10614](https://togithub.com/phpstan/phpstan/issues/10614) - fix type of `$a?->b::c()` and `$a?->b::$c` ([#2933](https://togithub.com/phpstan/phpstan-src/pull/2933)), thanks [@schlndh](https://togithub.com/schlndh)! - fix `fn() => __FUNCTION__` and `__METHOD__` ([#2934](https://togithub.com/phpstan/phpstan-src/pull/2934)), thanks [@schlndh](https://togithub.com/schlndh)! - Some sort functions do not preserve a list (phpstan/phpstan-src@034f731, phpstan/phpstan-src@0977a7b), [#10627](https://togithub.com/phpstan/phpstan/issues/10627) - ArgumentsNormalizer - keep named arguments for unknown parameters (phpstan/phpstan-src@ad34452), [#10628](https://togithub.com/phpstan/phpstan/issues/10628) - Check `T of mixed&Foo` and `T of mixed|Foo` ([#2940](https://togithub.com/phpstan/phpstan-src/pull/2940)), thanks [@schlndh](https://togithub.com/schlndh)! - Use narrowed conditional type if/else types for subtype checks ([#2948](https://togithub.com/phpstan/phpstan-src/pull/2948)), [#10622](https://togithub.com/phpstan/phpstan/issues/10622), thanks [@rvanvelzen](https://togithub.com/rvanvelzen)! - Fix `isSuperTypeOf` of callable/Closure when parameter count differ ([#2949](https://togithub.com/phpstan/phpstan-src/pull/2949)), [#10594](https://togithub.com/phpstan/phpstan/issues/10594), thanks [@takaram](https://togithub.com/takaram)! # Function signature fixes 🤖 - Fix `ReflectionFunctionAbstract::getExtension` return type (phpstan/phpstan-src@2ece1f8) - Correct return type of `date_sun_info()` function ([#2947](https://togithub.com/phpstan/phpstan-src/pull/2947)), thanks [@zonuexe](https://togithub.com/zonuexe)! - Fix return values of `mysqli get_warnings` ([#2929](https://togithub.com/phpstan/phpstan-src/pull/2929)), thanks [@janedbal](https://togithub.com/janedbal)! # Internals 🔍 - Replace composer-require-checker with composer-dependency-analyser ([#2875](https://togithub.com/phpstan/phpstan-src/pull/2875)), thanks [@janedbal](https://togithub.com/janedbal)! - Use `Type::isNull()` in `Nullsafe(MethodCall|PropertyFetch)Rule` ([#2942](https://togithub.com/phpstan/phpstan-src/pull/2942)), thanks [@takaram](https://togithub.com/takaram)! </details> <details> <summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary> ### [`v10.5.12`](https://togithub.com/sebastianbergmann/phpunit/releases/tag/10.5.12) [Compare Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.5.11...10.5.12) ##### Fixed - [#5652](https://togithub.com/sebastianbergmann/phpunit/issues/5652): `HRTime::duration()` throws `InvalidArgumentException` *** [How to install or update PHPUnit](https://docs.phpunit.de/en/10.5/installation.html) </details> <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.23.0`](https://togithub.com/vimeo/psalm/releases/tag/5.23.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.2...5.23.0)  #### What's Changed ##### Features - Update PHP 8.2 stubs to include `SensitiveParameterValue` by [@gsteel](https://togithub.com/gsteel) in [vimeo/psalm#10726 - Add list of statements to BeforeFileAnalysisEvent by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10728 - Forbid iterating over generators with non-nullable `send()` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10697 - Initial support for named parameters for callables by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10772 ##### Fixes - Improve randomizer stubs by [@danog](https://togithub.com/danog) in [vimeo/psalm#10709 - Fix detecting magic static methods by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10704 - Fix non-empty-lowercase-string handling with literal non-lowercase strings by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10722 - Fix RiskyTruthyFalsyComparison irrelevant errors when there is no explicit truthy/falsy type by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10733 - Allow `Override` attribute to be used in pure contexts by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10734 - Revert "Allow tainted numerics except for 'html' and 'has_quotes'" by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10729 - Fix loading stubs from phar file on Windows by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10748 - Fix a false flag issue with InvalidConstantAssignmentValue by [@MelechMizrachi](https://togithub.com/MelechMizrachi) in [vimeo/psalm#10738 - Set inside_isset false when analyzing ArrayDimFetch index by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10752 - Set inside_isset = false when analyzing arguments by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10753 - Fix PHP notice - crash on invalid taint-escape by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10760 - Fix version comparison for `@since` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10764 - Since annotations outside phpstub should not infer php version by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10769 - Backport `WeakMap` iterator fix from `master` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10778 - Namespace anonymous classes by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10779 - Update CallMap for sqlsrv_connect and sqlsrv_errors to match reflection by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10781 - `$resource` parameter of `mkdir()` is nullable since PHP 7.3 by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10802 - Use wider class-string when combining class strings with intersections by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10800 ##### Internal changes - Use TaintKind/TaintKindGroup constants instead of string values by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10746 - Skip symlink test on Windows by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10749 - Avoid duplicating code for RiskyTruthyFalsyComparison by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10765 - fix PHP 8 tests running with wrong --php-version=/phpVersion= if not explicitly specified by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10776 - CS fix by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10801 #### New Contributors - [@MelechMizrachi](https://togithub.com/MelechMizrachi) made their first contribution in [vimeo/psalm#10738 **Full Changelog**: vimeo/psalm@5.22.2...5.23.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-php).  Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vimeo/psalm](https://togithub.com/vimeo/psalm) | `5.22.1` -> `5.23.1` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.22.1/5.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.22.1/5.23.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.23.1`](https://togithub.com/vimeo/psalm/releases/tag/5.23.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.23.0...5.23.1)  #### What's Changed ##### Fixes - Fixed analysis of existing static methods if the `__callStatic()` method exists by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10812 **Full Changelog**: vimeo/psalm@5.23.0...5.23.1 ### [`v5.23.0`](https://togithub.com/vimeo/psalm/releases/tag/5.23.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.2...5.23.0)  #### What's Changed ##### Features - Update PHP 8.2 stubs to include `SensitiveParameterValue` by [@gsteel](https://togithub.com/gsteel) in [vimeo/psalm#10726 - Add list of statements to BeforeFileAnalysisEvent by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10728 - Forbid iterating over generators with non-nullable `send()` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10697 - Initial support for named parameters for callables by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10772 ##### Fixes - Improve randomizer stubs by [@danog](https://togithub.com/danog) in [vimeo/psalm#10709 - Fix detecting magic static methods by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10704 - Fix non-empty-lowercase-string handling with literal non-lowercase strings by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10722 - Fix RiskyTruthyFalsyComparison irrelevant errors when there is no explicit truthy/falsy type by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10733 - Allow `Override` attribute to be used in pure contexts by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10734 - Revert "Allow tainted numerics except for 'html' and 'has_quotes'" by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10729 - Fix loading stubs from phar file on Windows by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10748 - Fix a false flag issue with InvalidConstantAssignmentValue by [@MelechMizrachi](https://togithub.com/MelechMizrachi) in [vimeo/psalm#10738 - Set inside_isset false when analyzing ArrayDimFetch index by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10752 - Set inside_isset = false when analyzing arguments by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10753 - Fix PHP notice - crash on invalid taint-escape by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10760 - Fix version comparison for `@since` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10764 - Since annotations outside phpstub should not infer php version by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10769 - Backport `WeakMap` iterator fix from `master` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10778 - Namespace anonymous classes by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10779 - Update CallMap for sqlsrv_connect and sqlsrv_errors to match reflection by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10781 - `$resource` parameter of `mkdir()` is nullable since PHP 7.3 by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10802 - Use wider class-string when combining class strings with intersections by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10800 ##### Internal changes - Use TaintKind/TaintKindGroup constants instead of string values by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10746 - Skip symlink test on Windows by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10749 - Avoid duplicating code for RiskyTruthyFalsyComparison by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10765 - fix PHP 8 tests running with wrong --php-version=/phpVersion= if not explicitly specified by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10776 - CS fix by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10801 #### New Contributors - [@MelechMizrachi](https://togithub.com/MelechMizrachi) made their first contribution in [vimeo/psalm#10738 **Full Changelog**: vimeo/psalm@5.22.2...5.23.0 ### [`v5.22.2`](https://togithub.com/vimeo/psalm/releases/tag/5.22.2) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.1...5.22.2)  #### What's Changed ##### Fixes - Catch missing classlike exceptions during scanning by [@weirdan](https://togithub.com/weirdan) and [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10720 **Full Changelog**: vimeo/psalm@5.22.1...5.22.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Gashmob/project-templates).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [vimeo/psalm](https://togithub.com/vimeo/psalm) | `~5.17.0` -> `~5.24.0` | [![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.17.0/5.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.17.0/5.24.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.24.0`](https://togithub.com/vimeo/psalm/releases/tag/5.24.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.23.1...5.24.0)  #### What's Changed ##### Features - Allow specifying flags to Codebase::isTypeContainedByType by [@danog](https://togithub.com/danog) in [vimeo/psalm#10829 - Allow more callable types as subtypes of `callable` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10805 - Report `parent` being used in callable context when the class does not extend anything by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10838 - Report error for additional deprecated arg types in PHP 8.1/8.3 by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10824 - Add MissingClassConstType Issue by [@jack-worman](https://togithub.com/jack-worman) in [vimeo/psalm#10828 - Enforce parameter names for consistent constructors by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10821 - Add misc missing errors for invalid callable methods by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10839 ##### Fixes - Forbid named arguments for ArrayAcccess methods by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10804 - Don't crash on invalid templates by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10806 - report error for single param name mismatch too since named args can even be used then by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10822 - add support for named arguments for filter_var and filter_input by [@pilif](https://togithub.com/pilif) in [vimeo/psalm#10815 - When inside isset, make array fetch result nullable by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10756 - Promoted properties missing in extended \__construct should report PropertyNotSetInConstructor by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10817 - Updating signature of `getmxrr()` by [@ThomasLandauer](https://togithub.com/ThomasLandauer) in [vimeo/psalm#10847 - Improve string-int juggle consistency in array keys and display for int-like strings in type by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10814 - Fix storage not available in thread for intersection doc types by [@simonberger](https://togithub.com/simonberger) in [vimeo/psalm#10856 - Don't emit MissingOverrideAttribute for implicit Stringable implementations by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10858 - Specify array return type of session_get_cookie_params by [@jorgsowa](https://togithub.com/jorgsowa) in [vimeo/psalm#10859 - Unknown [@psalm](https://togithub.com/psalm) annotation should not make whole docblock invalid by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10885 - Add `mail` to impure functions list by [@smaddock](https://togithub.com/smaddock) in [vimeo/psalm#10923 - Update PHP 8.2 Call map delta with refined types for string comparison functions by [@gsteel](https://togithub.com/gsteel) in [vimeo/psalm#10883 ##### Docs - document that [@psalm-internal](https://togithub.com/psalm-internal) works for namespace + class too by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10866 ##### Internal changes - fix tests running with other than called PHP binary if called with a non-default PHP binary by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10842 - Explicitly set value in config to fix warning in tests by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10843 - \[PHP 8.4] Fixes for implicit nullability deprecation by [@Ayesh](https://togithub.com/Ayesh) in [vimeo/psalm#10832 - Throw exception instead of silently logging issues occurred during scan by [@danog](https://togithub.com/danog) in [vimeo/psalm#10902 ##### Other changes - Fix conditional on non empty literal string by [@VincentLanglet](https://togithub.com/VincentLanglet) in [vimeo/psalm#10912 - Ignore jsonSerialize for implementors of JsonSerializable by [@josephwynn-sc](https://togithub.com/josephwynn-sc) in [vimeo/psalm#10891 - Add XML functions to ImpureFunctionsList [#10882](https://togithub.com/vimeo/psalm/issues/10882) by [@DKhalil](https://togithub.com/DKhalil) in [vimeo/psalm#10887 #### New Contributors - [@Ayesh](https://togithub.com/Ayesh) made their first contribution in [vimeo/psalm#10832 - [@smaddock](https://togithub.com/smaddock) made their first contribution in [vimeo/psalm#10923 - [@josephwynn-sc](https://togithub.com/josephwynn-sc) made their first contribution in [vimeo/psalm#10891 - [@DKhalil](https://togithub.com/DKhalil) made their first contribution in [vimeo/psalm#10887 **Full Changelog**: vimeo/psalm@5.23.1...5.24.0 ### [`v5.23.1`](https://togithub.com/vimeo/psalm/releases/tag/5.23.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.23.0...5.23.1)  #### What's Changed ##### Fixes - Fixed analysis of existing static methods if the `__callStatic()` method exists by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10812 **Full Changelog**: vimeo/psalm@5.23.0...5.23.1 ### [`v5.23.0`](https://togithub.com/vimeo/psalm/releases/tag/5.23.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.2...5.23.0)  #### What's Changed ##### Features - Update PHP 8.2 stubs to include `SensitiveParameterValue` by [@gsteel](https://togithub.com/gsteel) in [vimeo/psalm#10726 - Add list of statements to BeforeFileAnalysisEvent by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10728 - Forbid iterating over generators with non-nullable `send()` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10697 - Initial support for named parameters for callables by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10772 ##### Fixes - Improve randomizer stubs by [@danog](https://togithub.com/danog) in [vimeo/psalm#10709 - Fix detecting magic static methods by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10704 - Fix non-empty-lowercase-string handling with literal non-lowercase strings by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10722 - Fix RiskyTruthyFalsyComparison irrelevant errors when there is no explicit truthy/falsy type by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10733 - Allow `Override` attribute to be used in pure contexts by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10734 - Revert "Allow tainted numerics except for 'html' and 'has_quotes'" by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10729 - Fix loading stubs from phar file on Windows by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10748 - Fix a false flag issue with InvalidConstantAssignmentValue by [@MelechMizrachi](https://togithub.com/MelechMizrachi) in [vimeo/psalm#10738 - Set inside_isset false when analyzing ArrayDimFetch index by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10752 - Set inside_isset = false when analyzing arguments by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10753 - Fix PHP notice - crash on invalid taint-escape by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10760 - Fix version comparison for `@since` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10764 - Since annotations outside phpstub should not infer php version by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10769 - Backport `WeakMap` iterator fix from `master` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10778 - Namespace anonymous classes by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10779 - Update CallMap for sqlsrv_connect and sqlsrv_errors to match reflection by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10781 - `$resource` parameter of `mkdir()` is nullable since PHP 7.3 by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10802 - Use wider class-string when combining class strings with intersections by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10800 ##### Internal changes - Use TaintKind/TaintKindGroup constants instead of string values by [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10746 - Skip symlink test on Windows by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10749 - Avoid duplicating code for RiskyTruthyFalsyComparison by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10765 - fix PHP 8 tests running with wrong --php-version=/phpVersion= if not explicitly specified by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10776 - CS fix by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10801 #### New Contributors - [@MelechMizrachi](https://togithub.com/MelechMizrachi) made their first contribution in [vimeo/psalm#10738 **Full Changelog**: vimeo/psalm@5.22.2...5.23.0 ### [`v5.22.2`](https://togithub.com/vimeo/psalm/releases/tag/5.22.2) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.1...5.22.2)  #### What's Changed ##### Fixes - Catch missing classlike exceptions during scanning by [@weirdan](https://togithub.com/weirdan) and [@ohader](https://togithub.com/ohader) in [vimeo/psalm#10720 **Full Changelog**: vimeo/psalm@5.22.1...5.22.2 ### [`v5.22.1`](https://togithub.com/vimeo/psalm/releases/tag/5.22.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.22.0...5.22.1)  #### What's Changed ##### Fixes - Improve parsing of `@psalm-type` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10713 **Full Changelog**: vimeo/psalm@5.22.0...5.22.1 ### [`v5.22.0`](https://togithub.com/vimeo/psalm/releases/tag/5.22.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.21.1...5.22.0)  #### What's Changed ##### Features - Allow inline comments in typedef shapes by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10623 - allow typedef imports from any kind of classlike by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10625 - Allow enum cases to be global constants by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10634 - New InvalidOverride issue for Override attribute by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10644 - Analyze dynamic names for static property and const fetches by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10629 - New MissingOverrideAttribute issue by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10651 - Flag `stdClass::__construct()` calls that have arguments by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10661 - Improve Reflection stubs by [@vudaltsov](https://togithub.com/vudaltsov) in [vimeo/psalm#10091 - Forbid constructors from returning any values by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10686 - Report first class callables generated for unknown static methods by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10691 - Process `@psalm-this-out` on `__construct()` as well by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10690 - Report invalid number of arguments for psalm-taint-\* by [@staabm](https://togithub.com/staabm) in [vimeo/psalm#10699 ##### Fixes - Fix ownerDocument type in dom-ext classes by [@fluffycondor](https://togithub.com/fluffycondor) in [vimeo/psalm#10619 - Fix numeric scalar validate filter var input return type wrong by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10621 - Stable baseline by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10633 - Allow sebastian/diff v6 by [@simPod](https://togithub.com/simPod) in [vimeo/psalm#10639 - CallMap: Adjust return type for `inotify_add_watch()` to `int|false` by [@UlrichEckhardt](https://togithub.com/UlrichEckhardt) in [vimeo/psalm#10637 - Fix check-type when using builtin types from within a namespace by [@robchett](https://togithub.com/robchett) in [vimeo/psalm#10648 - Do not add `callable` as a native property type by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10654 - Fix additional places where base_dir was broken due to missing separator by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10630 - Late binding of enum cases by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10655 - Suppress `UndefinedClass` in `whatever_exists()` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10659 - Fix parsing magic method annotations by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10665 - Strip callmap prefixes from parameter names by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10666 - Narrow `ord()` return type to `int<0,255>` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10676 - Template union object incorrect assertions by [@robchett](https://togithub.com/robchett) in [vimeo/psalm#10677 - Don't show backtrace in `InvalidDocblock` issue message by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10679 - Class consts in array shapes by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10678 - Prevent mixed|null by [@robchett](https://togithub.com/robchett) in [vimeo/psalm#10675 ##### Internal changes - Drop unused local composer repo by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10647 - Clarify that Pull request labels failure is to be resolved by maintainers by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10649 - Fix unstable `hasFullyQualified(Interface|Enum)()` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10603 - Revert partial mistakenly pushed fix by [@danog](https://togithub.com/danog) in [vimeo/psalm#10671 **Full Changelog**: vimeo/psalm@5.21.1...5.22.0 ### [`v5.21.1`](https://togithub.com/vimeo/psalm/releases/tag/5.21.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.21.0...5.21.1)  #### What's Changed ##### Fixes - Fix baseline loading for path specified on the command line by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10628 **Full Changelog**: vimeo/psalm@5.21.0...5.21.1 ### [`v5.21.0`](https://togithub.com/vimeo/psalm/releases/tag/5.21.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.20.0...5.21.0)  #### What's Changed ##### Features - Allow importing typedefs from enums by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10617 ##### Fixes - Fix [#10552](https://togithub.com/vimeo/psalm/issues/10552) by [@danog](https://togithub.com/danog) in [vimeo/psalm#10572 - Unit test improvements for php-parser 5 by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10574 - Fix template replacement edge case by [@klimick](https://togithub.com/klimick) in [vimeo/psalm#10586 - Switch condition order by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10594 - Partial revert "Fix auto completion by partial property or method" by [@issidorov](https://togithub.com/issidorov) in [vimeo/psalm#10588 - \[LSP] Add issue type in description by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10607 - Do not validate callable arguments in lenient contexts by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10601 - `readgzfile()` is impure by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10600 - Allow properties on intersections with enum interfaces by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10599 - `key_exists()` is an alias for `array_key_exists()` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10598 - Fix language server running with `opcache.save_comments=0` by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10614 - Report `MissingConstructor` for natively typed mixed properties by [@weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10615 ##### Internal changes - Bump actions/cache from 3 to 4 by [@dependabot](https://togithub.com/dependabot) in [vimeo/psalm#10584 - Baseline update by [@jorgsowa](https://togithub.com/jorgsowa) in [vimeo/psalm#10593 - Re-work CheckTrivialExprVisitor by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10612 - Minor php-parser tweaks by [@edsrzf](https://togithub.com/edsrzf) in [vimeo/psalm#10605 #### New Contributors - [@jorgsowa](https://togithub.com/jorgsowa) made their first contribution in [vimeo/psalm#10593 **Full Changelog**: vimeo/psalm@5.20.0...5.21.0 ### [`v5.20.0`](https://togithub.com/vimeo/psalm/releases/tag/5.20.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.19.1...5.20.0)  #### What's Changed ##### Features - report error for non-strict or empty comparison on truthy+falsy union by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10502 ##### Fixes - Fix template, conditional array keys by [@danog](https://togithub.com/danog) in [vimeo/psalm#10568 **Full Changelog**: vimeo/psalm@5.19.1...5.20.0 ### [`v5.19.1`](https://togithub.com/vimeo/psalm/releases/tag/5.19.1) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.19.0...5.19.1)  #### What's Changed ##### Fixes - Deprecated Template Classes are not ignored by [@psalm-suppress](https://togithub.com/psalm-suppress) DeprecatedClass by [@samlitowitz](https://togithub.com/samlitowitz) in [vimeo/psalm#10518 - Implement \__set method in SimpleXMLElement stub by [@kthaler](https://togithub.com/kthaler) in [vimeo/psalm#10536 - Make getrandmax type more specific and unserialize to require class-string by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10540 - Fix mb_get_info can return null - CI failing bc of reflection by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10543 - make basename & dirname return types more specific by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10545 - add support for extract to set variables for keyed arrays and respect EXTR_SKIP by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10544 - remove redundat directory separator which caused "//" in path not found errors by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10542 - Fix empty literal string becomes non-empty-string by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10499 #### New Contributors - [@samlitowitz](https://togithub.com/samlitowitz) made their first contribution in [vimeo/psalm#10518 - [@kthaler](https://togithub.com/kthaler) made their first contribution in [vimeo/psalm#10536 **Full Changelog**: vimeo/psalm@5.19.0...5.20.0 ### [`v5.19.0`](https://togithub.com/vimeo/psalm/releases/tag/5.19.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.18.0...5.19.0)  #### What's Changed ##### Features - Reduce memory consumption of caching and parallel processing without igbinary by [@sj-i](https://togithub.com/sj-i) in [vimeo/psalm#10532 - filter_input & filter_var return type more specific by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10498 ##### Fixes - strtok always returns a non-empty-string when it does not return false by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10497 - Fix [#10512](https://togithub.com/vimeo/psalm/issues/10512): Fixed SessionUpdateTimestampHandlerInterface parameter names by [@zerkms](https://togithub.com/zerkms) in [vimeo/psalm#10524 - Fix [GH-10465](https://togithub.com/vimeo/psalm/issues/10465) by [@florisluiten](https://togithub.com/florisluiten) in [vimeo/psalm#10483 - Fix callable without args not handled correctly by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10500 - Add error when using readonly property in by-ref arg by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10505 - fix: [#10496](https://togithub.com/vimeo/psalm/issues/10496) [#10503](https://togithub.com/vimeo/psalm/issues/10503) by [@ging-dev](https://togithub.com/ging-dev) in [vimeo/psalm#10508 #### New Contributors - [@florisluiten](https://togithub.com/florisluiten) made their first contribution in [vimeo/psalm#10483 **Full Changelog**: vimeo/psalm@5.18.0...5.19.0 ### [`v5.18.0`](https://togithub.com/vimeo/psalm/releases/tag/5.18.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.17.0...5.18.0)  ##### What's Changed ##### Features - Add support for Override attribute by [@delolmo](https://togithub.com/delolmo) in [vimeo/psalm#10493 ##### Fixes - Fix [#10460](https://togithub.com/vimeo/psalm/issues/10460) by [@danog](https://togithub.com/danog) in [vimeo/psalm#10464 - Emit AfterCodebasePopulatedEvent even on partial scans by [@danog](https://togithub.com/danog) in [vimeo/psalm#10457 - Small assertion fix by [@danog](https://togithub.com/danog) in [vimeo/psalm#10455 - Fix shaped array class string key combination by [@danog](https://togithub.com/danog) in [vimeo/psalm#10450 - Fix remaining POSIX-only absolute path detection by [@theodorejb](https://togithub.com/theodorejb) in [vimeo/psalm#10452 - dont combine empty string with numeric-string by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10459 - Fix type not equal when parent by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10477 - Use same parameter names in stubs by [@danog](https://togithub.com/danog) in [vimeo/psalm#10480 - fix false positive ArgumentTypeCoercion for callback param by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10454 - report error for invalid array key type by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10481 - fix literal int/string comparisons only using one literal by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10484 - add InvalidArgument error when passing false to true param by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10488 - Fix Uncaught RuntimeException: PHP Error: Uninitialized string offset 0 when $pattern is empty by [@iMu3ic](https://togithub.com/iMu3ic) in [vimeo/psalm#10489 ##### Internal changes - fix composer scripts running with inconsistent php versions by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10463 - update fidry/cpu-core-counter dependency by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10456 - fix psalm v4 hardcoded in tests by [@kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10475 ##### New Contributors - [@iMu3ic](https://togithub.com/iMu3ic) made their first contribution in [vimeo/psalm#10489 - [@delolmo](https://togithub.com/delolmo) made their first contribution in [vimeo/psalm#10493 **Full Changelog**: vimeo/psalm@5.17.0...5.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

issidorov added 15 commits February 13, 2024 17:25

Add argument with_pseudo for method finding

29b4c38

Add issue message for magic methods

083b8e2

Resolved all tests

5f89fa1

Resolved problem: ``` 1) MagicMethodAnnotationTest::testSealAllMethodsSetToFalseWithStatic Psalm\Exception\CodeException: UndefinedMagicMethod - somefile.php:8:15 - Magic method B::foo does not exist ```

Failed and regression tests with usage config

4fce070

Failed test: ``` 1) MagicMethodAnnotationTest::testAnnotationWithoutCallConfigWithExtendsWithStatic Failed asserting that exception of type "Psalm\Exception\CodeException" is thrown. ```

weirdan self-requested a review February 13, 2024 20:46

weirdan requested changes Feb 13, 2024

View reviewed changes

issidorov commented Feb 14, 2024

View reviewed changes

tests/Traits/InvalidCodeAnalysisWithIssuesTestTrait.php Outdated Show resolved Hide resolved

Fix message in TestCase::assertHasIssueType

db92991

Apply suggestions from code review. Co-authored-by: Bruce Weirdan <weirdan@gmail.com>

issidorov commented Feb 14, 2024

View reviewed changes

tests/TestCase.php Outdated Show resolved Hide resolved

issidorov added 3 commits February 14, 2024 15:41

Use snake_case in TestCase::assertHasIssueType

cfd0fd1

Rename to TestCase::assertHasIssue

08a479a

Fix description in InvalidCodeAnalysisWithIssuesTestTrait

b7a2080

issidorov force-pushed the fix-detecting-magic-static-methods branch from 49c6587 to 662fe82 Compare February 14, 2024 17:16

issidorov requested a review from weirdan February 14, 2024 17:25

weirdan requested changes Feb 14, 2024

View reviewed changes

tests/MagicMethodAnnotationTest.php Outdated Show resolved Hide resolved

tests/Traits/InvalidCodeAnalysisWithIssuesTestTrait.php Outdated Show resolved Hide resolved

issidorov force-pushed the fix-detecting-magic-static-methods branch from d31167f to 206daa8 Compare February 14, 2024 22:12

issidorov and others added 3 commits February 14, 2024 22:17

Fix description InvalidCodeAnalysisWithIssuesTestTrait

3724062

Co-authored-by: Bruce Weirdan <weirdan@gmail.com>

issidorov force-pushed the fix-detecting-magic-static-methods branch from 206daa8 to 8a70bc2 Compare February 14, 2024 22:19

issidorov requested a review from weirdan February 14, 2024 22:34

weirdan approved these changes Feb 14, 2024

View reviewed changes

weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Feb 14, 2024

weirdan requested review from danog and orklah February 14, 2024 22:49

weirdan merged commit d3c1222 into vimeo:5.x Feb 17, 2024
50 of 51 checks passed

SCIF mentioned this pull request Mar 11, 2024

Method __callStatic() breaks asserts on 5.23 #10807

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix detecting magic static methods #10704

Fix detecting magic static methods #10704

issidorov commented Feb 13, 2024

weirdan Feb 13, 2024

issidorov Feb 14, 2024

weirdan commented Feb 17, 2024

Fix detecting magic static methods #10704

Fix detecting magic static methods #10704

Conversation

issidorov commented Feb 13, 2024

weirdan Feb 13, 2024

Choose a reason for hiding this comment

issidorov Feb 14, 2024

Choose a reason for hiding this comment

weirdan commented Feb 17, 2024