Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid iterating over generators with non-nullable send() #10697

Merged
merged 4 commits into from Feb 27, 2024
Merged

Forbid iterating over generators with non-nullable send() #10697

merged 4 commits into from Feb 27, 2024

Commits on Feb 27, 2024

  1. Forbid iterating over generators with non-nullable send() 

    Fixes vimeo#6985
    @weirdan
    weirdan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8a0bc19 View commit details
    Browse the repository at this point in the history

  2. Strip null used to signify completed iterations in foreach context 

    Even though `Generator::current()` can return `null` once generator is
exhausted, `foreach()` never iterates after iterator ends, so we can
safely remove `null` (unless, of course, generator can yield `null`).
    @weirdan
    weirdan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    27461c9 View commit details
    Browse the repository at this point in the history

  3. Disabled wrong test

    @weirdan
    weirdan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4eec8bb View commit details
    Browse the repository at this point in the history

  4. Let's see what breaks without this hack

    @weirdan
    weirdan committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    0ce62a5 View commit details
    Browse the repository at this point in the history