Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unstable hasFullyQualified(Interface|Enum)() #10603

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Fix unstable hasFullyQualified(Interface|Enum)() #10603

merged 6 commits into from
Feb 5, 2024

Commits on Jan 29, 2024

  1. Fix unstable hasFullyQualified(Interface|Enum)() 

    Before this change, calling:
```php
$classlikes->hasFullyQualifiedInterfaceName($i); // true
$classlikes->hasFullyQualifiedClassName($i); // false
$classlikes->hasFullyQualifiedInterfaceName($i); // false
```
would result in the last call returning `false`
    @weirdan
    weirdan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    67ba758 View commit details
    Browse the repository at this point in the history

  2. Reflection may reference interfaces and enums

    @weirdan
    weirdan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    58b7139 View commit details
    Browse the repository at this point in the history

  3. Un-ignore recursiveiteratoriterator::__construct

    @weirdan
    weirdan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    c935cc3 View commit details
    Browse the repository at this point in the history

  4. Un-ignore arrayobject::getiterator - appears it's been fixed too

    @weirdan
    weirdan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e876396 View commit details
    Browse the repository at this point in the history

  5. Fix test by preloading interface

    @weirdan
    weirdan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    b2aebd9 View commit details
    Browse the repository at this point in the history

  6. Drop suppression as the method is now used in tests

    @weirdan
    weirdan committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    e63db9c View commit details
    Browse the repository at this point in the history