Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant condition mixed type escape hatch & loose comparison int type shouldnt be mixed #10388

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Fix redundant condition mixed type escape hatch & loose comparison int type shouldnt be mixed #10388

merged 2 commits into from
Nov 21, 2023

Commits on Nov 21, 2023

  1. loose comparisons of int with string shouldn't change change the int … 

    …to empty-mixed
    @kkmuffme
    kkmuffme committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    d94f7bd View commit details
    Browse the repository at this point in the history

  2. Fix docblock mixed escape hatch 

    revert vimeo#7663 including previous from_docblock Mixed assignments, as the tests required 2 suppressions and created an escape hatch via mixed on higher psalm error levels, where mixed isn't reported, thus hiding potentially fatal bugs.
It's still possible to run the validation of docblock docs though: a @var declaration that contains both possible types, to ensure later code won't escape any checks (and no @psalm-suppress needed at all)

This is also a required preparation to fix some isset issues of vimeo#9759
    @kkmuffme
    kkmuffme committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    0d7c5a2 View commit details
    Browse the repository at this point in the history