Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer PHP version checking #10129

Merged
merged 4 commits into from Aug 18, 2023
Merged

Nicer PHP version checking #10129

merged 4 commits into from Aug 18, 2023

Commits on Aug 18, 2023

  1. Fix PHP version checking 

    Separate condition to check both cases if the specified string is a valid version and if it is supported
Remove unsupported versions up to 7.4 from regex
    @Nitamet
    Nitamet committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5f40d26 View commit details
    Browse the repository at this point in the history

  2. Add versions 5.4-7.3 as supported

    @Nitamet
    Nitamet committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    2c7391a View commit details
    Browse the repository at this point in the history

  3. Add 8.3 as supported version

    @Nitamet
    Nitamet committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    18b74b1 View commit details
    Browse the repository at this point in the history

  4. Throw and catch exception when specified PHP version is invalid

    @Nitamet
    Nitamet committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    005eed3 View commit details
    Browse the repository at this point in the history