argv and argc were inconsistent in Context with VariableFetchAnalyzer #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why argv/argc are declared in context independently in the first place though
kkmuffme
force-pushed
the
inconsistent-argv-argc-in-context
branch
from
54a9b73
to
801cca2
Compare
|
@orklah please take a look at this and merge it. Perhaps open a new issue so other globals ($_POST? $_GET? $_SERVER?) should be added to context here too? (and the duplicate code for argv/argc removed) |
|
Thanks! Not sure why it's duplicated either |
orklah
added
the
release:fix
oguzhand95
pushed a commit
to cerbos/cerbos-sdk-php
that referenced
this pull request
Aug 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google/protobuf](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf-php)) | require | minor | `3.23.4` -> `3.24.1` | | [grpc/grpc](https://grpc.io) ([source](https://togithub.com/grpc/grpc-php)) | require | minor | `1.52.0` -> `1.57.0` | | [phpstan/phpstan](https://togithub.com/phpstan/phpstan) | require-dev | patch | `1.10.27` -> `1.10.29` | | [phpunit/phpunit](https://phpunit.de/) ([source](https://togithub.com/sebastianbergmann/phpunit)) | require-dev | patch | `10.3.1` -> `10.3.2` | | [vimeo/psalm](https://togithub.com/vimeo/psalm) | require-dev | minor | `5.14.1` -> `5.15.0` | --- ### Release Notes <details> <summary>protocolbuffers/protobuf-php (google/protobuf)</summary> ### [`v3.24.1`](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1) [Compare Source](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.24.0...v3.24.1) ### [`v3.24.0`](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0) [Compare Source](https://togithub.com/protocolbuffers/protobuf-php/compare/v3.23.4...v3.24.0) </details> <details> <summary>grpc/grpc-php (grpc/grpc)</summary> ### [`v1.57.0`](https://togithub.com/grpc/grpc-php/compare/v1.52.0...v1.57.0) [Compare Source](https://togithub.com/grpc/grpc-php/compare/v1.52.0...v1.57.0) </details> <details> <summary>phpstan/phpstan (phpstan/phpstan)</summary> ### [`v1.10.29`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.29) [Compare Source](https://togithub.com/phpstan/phpstan/compare/1.10.28...1.10.29) # Improvements 🔧 - Update nikic/php-parser to v4.17.1 - PHP 8.3 features are no longer parse errors. Full-fledged PHP 8.3 support is coming later this year. - Update BetterReflection to 6.12.0 # Bugfixes 🐛 - PHPStan Pro - when launching, `PHP_BINARY` needs to be escaped (phpstan/phpstan-src@2c7cfd8) # Function signature fixes 🤖 - Fix FTP-related function signatures ([#​2551](https://togithub.com/phpstan/phpstan-src/pull/2551)), thanks [@​thg2k](https://togithub.com/thg2k)! ### [`v1.10.28`](https://togithub.com/phpstan/phpstan/releases/tag/1.10.28) [Compare Source](https://togithub.com/phpstan/phpstan/compare/1.10.27...1.10.28) # Improvements 🔧 - Update BetterReflection to 6.12.0 (phpstan/phpstan-src@7c49c94) # Bugfixes 🐛 - Nullsafe operator on `null` results in `null` (phpstan/phpstan-src@5c40c85), [#​9721](https://togithub.com/phpstan/phpstan/issues/9721) - Properties set in the native constructor are initialized in additional constructors (phpstan/phpstan-src@1b0c6a0), [#​9619](https://togithub.com/phpstan/phpstan/issues/9619) - Fix performance problem with nested BooleanOr and BooleanAnd (phpstan/phpstan-src@9adae6c), [#​9690](https://togithub.com/phpstan/phpstan/issues/9690), [#​9676](https://togithub.com/phpstan/phpstan/issues/9676) - CallableTypeHelper - copy variadic parameters if the accepting closure has more parameters (phpstan/phpstan-src@31ed326), [#​9699](https://togithub.com/phpstan/phpstan/issues/9699) # Internals 🔍 - Simplify access to ClassReflection in ClassPropertyNode ([#​2565](https://togithub.com/phpstan/phpstan-src/pull/2565)), thanks [@​mad-briller](https://togithub.com/mad-briller)! </details> <details> <summary>sebastianbergmann/phpunit (phpunit/phpunit)</summary> ### [`v10.3.2`](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2) [Compare Source](https://togithub.com/sebastianbergmann/phpunit/compare/10.3.1...10.3.2) </details> <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.15.0`](https://togithub.com/vimeo/psalm/releases/tag/5.15.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.14.1...5.15.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Check if argument passed to isset() is not a variable by [@​Nitamet](https://togithub.com/Nitamet) in [vimeo/psalm#10068 - Fix [#​9997](https://togithub.com/vimeo/psalm/issues/9997) dynamic properties on SimpleXmlElement by [@​ygottschalk](https://togithub.com/ygottschalk) in [vimeo/psalm#10049 - Nicer PHP version checking by [@​Nitamet](https://togithub.com/Nitamet) in [vimeo/psalm#10129 ##### Fixes - Fixed `DOMDocument::load*` signatures by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10073 - make (s)printf error reporting more correct/literal by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10088 - Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by [@​kubawerlos](https://togithub.com/kubawerlos) in [vimeo/psalm#10104 - mysqli_field_seek returns true by [@​kamil-tekiela](https://togithub.com/kamil-tekiela) in [vimeo/psalm#10107 - Fix bcdiv nullable scale stub by [@​TheDevick](https://togithub.com/TheDevick) in [vimeo/psalm#10106 - Cleanup `test` command and `fixAll` action by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10108 - Correct type for `$enum->name` by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10109 - argv and argc were inconsistent in Context with VariableFetchAnalyzer by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10093 - Fix `hash_pbkdf2` `$options` parameter by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10110 - Forbid faulty `nikic/php-parser` version by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10112 - `strip_tags()/$allowed_tags` can accept arrays since 7.4 by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10122 - Fix crash when assertion array is not a list by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10123 - Fix crash on array access to undefined class by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10134 - Correct exit code for invalid version format by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10135 #### New Contributors - [@​Nitamet](https://togithub.com/Nitamet) made their first contribution in [vimeo/psalm#10068 - [@​TheDevick](https://togithub.com/TheDevick) made their first contribution in [vimeo/psalm#10106 **Full Changelog**: vimeo/psalm@5.14.1...5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cerbos/cerbos-sdk-php). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
tcarrio
pushed a commit
to open-feature/php-sdk
that referenced
this pull request
Sep 21, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [vimeo/psalm](https://togithub.com/vimeo/psalm) | require-dev | minor | `~5.14.0` -> `~5.15.0` | --- ### Release Notes <details> <summary>vimeo/psalm (vimeo/psalm)</summary> ### [`v5.15.0`](https://togithub.com/vimeo/psalm/releases/tag/5.15.0) [Compare Source](https://togithub.com/vimeo/psalm/compare/5.14.1...5.15.0) <!-- Release notes generated using configuration in .github/release.yml at 5.x --> #### What's Changed ##### Features - Check if argument passed to isset() is not a variable by [@​Nitamet](https://togithub.com/Nitamet) in [vimeo/psalm#10068 - Fix [#​9997](https://togithub.com/vimeo/psalm/issues/9997) dynamic properties on SimpleXmlElement by [@​ygottschalk](https://togithub.com/ygottschalk) in [vimeo/psalm#10049 - Nicer PHP version checking by [@​Nitamet](https://togithub.com/Nitamet) in [vimeo/psalm#10129 ##### Fixes - Fixed `DOMDocument::load*` signatures by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10073 - make (s)printf error reporting more correct/literal by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10088 - Fix parameter having `object` type in PHPDoc and only `&` in the method's definition, used with code having an object calling it's method with itself as an argument for mentioned parameter by [@​kubawerlos](https://togithub.com/kubawerlos) in [vimeo/psalm#10104 - mysqli_field_seek returns true by [@​kamil-tekiela](https://togithub.com/kamil-tekiela) in [vimeo/psalm#10107 - Fix bcdiv nullable scale stub by [@​TheDevick](https://togithub.com/TheDevick) in [vimeo/psalm#10106 - Cleanup `test` command and `fixAll` action by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10108 - Correct type for `$enum->name` by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10109 - argv and argc were inconsistent in Context with VariableFetchAnalyzer by [@​kkmuffme](https://togithub.com/kkmuffme) in [vimeo/psalm#10093 - Fix `hash_pbkdf2` `$options` parameter by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10110 - Forbid faulty `nikic/php-parser` version by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10112 - `strip_tags()/$allowed_tags` can accept arrays since 7.4 by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10122 - Fix crash when assertion array is not a list by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10123 - Fix crash on array access to undefined class by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10134 - Correct exit code for invalid version format by [@​weirdan](https://togithub.com/weirdan) in [vimeo/psalm#10135 #### New Contributors - [@​Nitamet](https://togithub.com/Nitamet) made their first contribution in [vimeo/psalm#10068 - [@​TheDevick](https://togithub.com/TheDevick) made their first contribution in [vimeo/psalm#10106 **Full Changelog**: vimeo/psalm@5.14.1...5.15.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40My4yIiwidXBkYXRlZEluVmVyIjoiMzYuNDMuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why argv/argc are declared in context independently in the first place though