Merge pull request #9435 from vimeo/revert-9434-array_pop-is-impure

vimeo · Mar 1, 2023 · 839dc10 · 839dc10
2 parents 83051cf + 5130563
commit 839dc10
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 25 deletions.
diff --git a/src/Psalm/Internal/Codebase/Functions.php b/src/Psalm/Internal/Codebase/Functions.php
@@ -476,7 +476,6 @@ public function isCallMapFunctionPure(
             'date_default_timezone_set', 'assert_options', 'setlocale',
             'set_exception_handler', 'set_time_limit', 'putenv', 'spl_autoload_register',
             'spl_autoload_unregister', 'microtime', 'array_rand', 'set_include_path',
-            'array_pop',
 
             // logging
             'openlog', 'syslog', 'error_log', 'define_syslog_variables',

diff --git a/tests/PureAnnotationTest.php b/tests/PureAnnotationTest.php
@@ -902,30 +902,6 @@ function (): void {}
                     ',
                 'error_message' => 'ImpureFunctionCall',
             ],
-            'array_popIsNotMutationFree' => [
-                'code' => <<<'PHP'
-                    <?php
-                    class Stack
-                    {
-                        /** @var array<string> */
-                        private array $stack = [];
-
-                        public function push(string $item): void
-                        {
-                            $this->stack[] = $item;
-                        }
-
-                        /** @psalm-mutation-free */
-                        public function next(): string|null
-                        {
-                            return array_pop($this->stack);
-                        }
-                    }
-                    PHP,
-                'error_message' => 'ImpureFunctionCall',
-                'ignored_issues' => [],
-                'php_version' => '8.0',
-            ],
         ];
     }
 }