Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
weirdan committed Feb 4, 2024
1 parent 8396360 commit 6d572a6
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions tests/OverrideTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;

use const DIRECTORY_SEPARATOR;

class OverrideTest extends TestCase
{
use ValidCodeAnalysisTestTrait;
Expand Down Expand Up @@ -83,7 +81,7 @@ class C {
public function f(): void {}
}
',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25',
'error_message' => 'InvalidOverride',
'error_levels' => [],
'php_version' => '8.3',
],
Expand All @@ -97,7 +95,7 @@ class C2 extends C {
public function f(): void {}
}
',
'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25',
'error_message' => 'MissingOverrideAttribute',
'error_levels' => [],
'php_version' => '8.3',
],
Expand All @@ -113,7 +111,7 @@ class C {
public function f(): void {}
}
',
'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:9:25',
'error_message' => 'MissingOverrideAttribute',
'error_levels' => [],
'php_version' => '8.3',
],
Expand All @@ -131,7 +129,7 @@ class C2 extends C {
public function __construct() {}
}
',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:10:25',
'error_message' => 'InvalidOverride',
'error_levels' => [],
'php_version' => '8.3',
],
Expand All @@ -145,7 +143,7 @@ interface I2 extends I {
public function f(): void;
}
',
'error_message' => 'MissingOverrideAttribute - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25',
'error_message' => 'MissingOverrideAttribute',
'error_levels' => [],
'php_version' => '8.3',
],
Expand All @@ -160,7 +158,7 @@ class C2 extends C {
private function f(): void {}
}
',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:7:25',
'error_message' => 'InvalidOverride',
'error_levels' => [],
'php_version' => '8.3',
],
Expand All @@ -171,7 +169,7 @@ interface I {
public function f(): void;
}
',
'error_message' => 'InvalidOverride - src' . DIRECTORY_SEPARATOR . 'somefile.php:3:25',
'error_message' => 'InvalidOverride',
'error_levels' => [],
'php_version' => '8.3',
],
Expand Down

0 comments on commit 6d572a6

Please sign in to comment.