fix failing tests

vimeo · Nov 13, 2023 · 5470724 · 5470724
1 parent 2da694a
commit 5470724
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/AssignmentAnalyzer.php
@@ -537,6 +537,7 @@ public static function analyze(
                 )) {
                     // if the error is suppressed, do not treat it as never anymore
                     $context->vars_in_scope[$var_id] = Type::getMixed();
+                    $context->has_returned = false;
                 }
 
                 $context->inside_assignment = $was_in_assignment;

diff --git a/tests/UnusedCodeTest.php b/tests/UnusedCodeTest.php
@@ -1349,7 +1349,7 @@ function bar(mixed $s) : string {
                      */
                     function foo() : void {}
 
-                    function bar($s) : void {}
+                    function bar(mixed $s) : void {}
 
                     /** @psalm-suppress NoValue */
                     bar(foo());