Fix crash on array access to undefined class

vimeo · Aug 20, 2023 · 4c58c93 · 4c58c93
1 parent 0922fa1
commit 4c58c93
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ArrayFetchAnalyzer.php
@@ -1737,8 +1737,10 @@ private static function handleArrayAccessOnNamedObject(
         ?Union &$array_access_type,
         bool &$has_array_access
     ): void {
+        $codebase = $statements_analyzer->getCodebase();
         if (strtolower($type->value) === 'simplexmlelement'
-            || $statements_analyzer->getCodebase()->classExtendsOrImplements($type->value, 'SimpleXMLElement')
+            || ($codebase->classExists($type->value)
+                && $codebase->classExtendsOrImplements($type->value, 'SimpleXMLElement'))
         ) {
             $call_array_access_type = new Union([new TNull(), new TNamedObject('SimpleXMLElement')]);
         } elseif (strtolower($type->value) === 'domnodelist' && $stmt->dim) {

diff --git a/tests/ArrayAccessTest.php b/tests/ArrayAccessTest.php
@@ -1199,6 +1199,27 @@ function f($p): int {
                 ',
                 'assertions' => ['$a===' => "array{1: 'b'}"],
             ],
+            'noCrashOnUnknownClassArrayAccess' => [
+                'code' => <<<'PHP'
+                <?php
+
+                namespace Psalmtest\Psalmtest;
+
+                use SomeMissingClass;
+
+                class Test
+                {
+                    public function f(): void {
+                        /** @var SomeMissingClass */
+                        $result = null;
+
+                        if ($result['errors'] === true) {}
+                    }
+                }
+                PHP,
+                'assertions' => [],
+                'error_levels' => ['UndefinedDocblockClass'],
+            ],
         ];
     }