[node] Add isomorphic functions #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 9ad8318 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Kikobeats
changed the title
Kikobeats
requested review from
TooTallNate,
EndangeredMassa,
styfle,
cb1kenobi and
Ethan-Arrowood
as code owners
EndangeredMassa
requested changes
Jun 5, 2023
there is a bug in node-fetch that requires to don't use localhost node-fetch/node-fetch#1624
cb1kenobi
suggested changes
Jun 6, 2023
| if (!message.startsWith('Error:')) { | ||
| message = `Error: ${message}`; | ||
| } | ||
| console.error(message); |
There was a problem hiding this comment.
This is an improvement, but I realized we show errors differently between startup/runtime and serverless-node/edge. We should standardize those differences, but not in this PR.
EndangeredMassa
approved these changes
Jun 6, 2023
cb1kenobi
approved these changes
Jun 6, 2023
TooTallNate
reviewed
Jun 6, 2023
| // @ts-expect-error - `node-fetch` Headers is missing `getAll()` | ||
| Headers, | ||
| }); | ||
| const toHeaders = buildToHeaders({ Headers }); |
There was a problem hiding this comment.
I don't understand how this TS error was fixed
There was a problem hiding this comment.
Upgrading @edge-runtime/node-utils fixed the issue I think because of this PR: vercel/edge-runtime#309
TooTallNate
approved these changes
Jun 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow using Web APIs in Serverless functions
More about that https://nextjs.org/docs/app/building-your-application/routing/router-handlers