[cli] replace console.log that communicates to user with output.log #11353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f9bdc90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
erikareads
force-pushed
the
erikarowland/zero-1759-convert-cases-of-consolelog-that-are-communicating-to-the
branch
from
4f4ffc6
to
d4b58e1
Compare
erikareads
changed the title
…olelog-that-are-communicating-to-the
erikareads
requested review from
TooTallNate,
EndangeredMassa,
trek,
onsclom and
jeffsee55
as code owners
…olelog-that-are-communicating-to-the
erikareads
commented
Apr 11, 2024
| @@ -95,8 +84,8 @@ export default async function add(client: Client): Promise<number> { | |||
| }); | |||
| } catch (err: unknown) { | |||
| if (isError(err) && err.message === 'USER_ABORT') { | |||
| console.log(info('No name specified')); | |||
| return gracefulExit(); | |||
| output.log('No name specified'); | |||
There was a problem hiding this comment.
Perhaps make an output.error?
jeffsee55
approved these changes
Apr 11, 2024
…olelog-that-are-communicating-to-the
…olelog-that-are-communicating-to-the
kodiakhq
bot
deleted the
erikarowland/zero-1759-convert-cases-of-consolelog-that-are-communicating-to-the
branch
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Apr 18, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@34.1.0 ### Minor Changes - Don't propagate legacy env VERCEL_ANALYTICS_ID if @vercel/speed-insights package is detected ([#11305](#11305)) ### Patch Changes - Replace console.log that communicates to user with client.output methods ([#11353](#11353)) - [cli] Do not pipe git stderr to user during successful `vc dev` run ([#11450](#11450)) - fix: Sort default team to the top of the selection list ([#11451](#11451)) - Updated dependencies \[[`993a60ef7`](993a60e), [`949d84ad1`](949d84a), [`5bb96ea07`](5bb96ea), [`fd8031874`](fd80318)]: - @vercel/next@4.2.1 ## @vercel/frameworks@3.0.2 ### Patch Changes - Update framework detection to support SolidStart v1 ([#11308](#11308)) ## @vercel/fs-detectors@5.2.3 ### Patch Changes - Updated dependencies \[[`5f72dc436`](5f72dc4)]: - @vercel/frameworks@3.0.2 ## @vercel/next@4.2.1 ### Patch Changes - [next] add streaming prerender group for actions ([#11454](#11454)) - [next] Ensure \_not-found is included properly in app router functions ([#11441](#11441)) - [next] add .action handling for dynamic routes ([#11461](#11461)) - [next] Remove un-necessary compressed function size calc/constraint ([#11442](#11442)) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have several instances of
console.logbeing used with colors or other indicators that they're trying to communicate to the user, and not in a way that makes sense for standard output. These should be migrated to use theclient.outputmethods where possible.